From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:33018 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbaI0Ho5 (ORCPT ); Sat, 27 Sep 2014 03:44:57 -0400 Received: by mail-pa0-f46.google.com with SMTP id kq14so1389652pab.33 for ; Sat, 27 Sep 2014 00:44:57 -0700 (PDT) Date: Sat, 27 Sep 2014 00:45:59 -0700 From: Omar Sandoval To: Joe Perches Cc: Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, "Paul E. McKenney" , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] Return a value from printk_ratelimited Message-ID: <20140927074559.GA30196@molino.home.network> References: <1411796891.21874.14.camel@joe-AO725> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1411796891.21874.14.camel@joe-AO725> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Sep 26, 2014 at 10:48:11PM -0700, Joe Perches wrote: > I'd prefer to keep it the way it is actually. > > I've submitted several patches to convert the int return > to void for printk derived functions recently. Alright, it doesn't seem like anyone feels strongly for keeping the return values, so I'll go ahead and submit a v4 that doesn't modify printk_ratelimited and doesn't return anything from the printk functions in rcustring.h unless there are any objections. -- Omar