From: David Sterba <dsterba@suse.cz>
To: dsterba@suse.cz, Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs: make free space cache less noisy
Date: Mon, 6 Oct 2014 19:08:23 +0200 [thread overview]
Message-ID: <20141006170823.GC11436@twin.jikos.cz> (raw)
In-Reply-To: <20141006164251.GB11436@twin.jikos.cz>
On Mon, Oct 06, 2014 at 06:42:51PM +0200, David Sterba wrote:
> On Wed, Oct 01, 2014 at 10:11:09AM -0400, Josef Bacik wrote:
> > Fsck only cares if the cache is really broken, so don't be noisy if the
> > generations don't match or other such errors. Thanks,
>
> Let's put the messages under a --verbose option if they're just noise.
> I'll send a followup patch.
The printf's are inside free-spache-cache.c so it would need to keep
some global state that is read in cmds-check.c and set from random other
files. This could be cleanly done by prefixing the printf messages the
same way the kernel printk works and then print only the messages below
the user-specified level. Also, using printk in sources that are (not
yet but will be) shared with kernel is IMHO a good practice.
As this is going to be a broader change, I'd like to think about it more
and for now will keep the patch out, I hope we can live with the noisy
messages.
next prev parent reply other threads:[~2014-10-06 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 14:11 [PATCH] Btrfs-progs: make free space cache less noisy Josef Bacik
2014-10-06 16:42 ` David Sterba
2014-10-06 17:08 ` David Sterba [this message]
2014-10-06 16:48 ` [PATCH] btrfs-progs: check, add verbosity level option David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006170823.GC11436@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).