From: David Sterba <dsterba@suse.cz>
To: Goffredo Baroncelli <kreijack@gmail.com>
Cc: linux-btrfs@vger.kernel.org, Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH][BTRFS-PROGS][CLEANUP] Remove gotos
Date: Mon, 22 Dec 2014 18:32:05 +0100 [thread overview]
Message-ID: <20141222173205.GD6490@twin.jikos.cz> (raw)
In-Reply-To: <1419185238-4254-2-git-send-email-kreijack@inwind.it>
... Subject: [PATCH][BTRFS-PROGS][CLEANUP] Remove gotos
You're being too creative with the subjects and lack the preferred
formatting. If you're going to submit more patches, please get it right
so I don't have to fix it repeatedly manually. There's a wiki page
https://btrfs.wiki.kernel.org/index.php/Developer's_FAQ
that should cover the topic.
On Sun, Dec 21, 2014 at 07:07:18PM +0100, Goffredo Baroncelli wrote:
> Change a spagetti-style code (there are some "interlaced" gotos) to
> a more modern style...
>
> This patch removes also some #define from utils.h, which define
> constants used only in cmds-filesystems.c . Instead an enum
> is used locally in cmds-filesystems.c .
That's an unrelated change, please put it into a separate patch.
next prev parent reply other threads:[~2014-12-22 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 18:07 [BTRFS-PROGS][PATCH][CLEANUP] Remove some gotos Goffredo Baroncelli
2014-12-21 18:07 ` [PATCH][BTRFS-PROGS][CLEANUP] Remove gotos Goffredo Baroncelli
2014-12-22 11:34 ` Satoru Takeuchi
2014-12-22 19:07 ` Goffredo Baroncelli
2014-12-24 3:04 ` Satoru Takeuchi
2014-12-22 17:32 ` David Sterba [this message]
2014-12-22 2:29 ` [BTRFS-PROGS][PATCH][CLEANUP] Remove some gotos Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222173205.GD6490@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kreijack@gmail.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).