From: Dave Chinner <david@fromorbit.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: "gux.fnst" <gux.fnst@cn.fujitsu.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: add regression test for remount with thread_pool resized
Date: Wed, 24 Dec 2014 07:47:52 +1100 [thread overview]
Message-ID: <20141223204752.GG4521@dastard> (raw)
In-Reply-To: <549914B4.8020001@cn.fujitsu.com>
On Tue, Dec 23, 2014 at 03:07:32PM +0800, Qu Wenruo wrote:
>
> -------- Original Message --------
> Subject: Re: [PATCH] btrfs: add regression test for remount with
> thread_pool resized
> From: gux.fnst <gux.fnst@cn.fujitsu.com>
> To: <fstests@vger.kernel.org>
> Date: 2014年09月17日 18:02
> >Hi,
> >
> > Could anyone help to review this patch? Thanks!
> >
> >Regards,
> >Xing Gu
> >
> >On 05/30/2014 04:52 PM, Xing Gu wrote:
> >>Regression test for resizing 'thread_pool' when remount the fs.
> >>
> >>Signed-off-by: Xing Gu <gux.fnst@cn.fujitsu.com>
> >>---
> >> tests/btrfs/055 | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> tests/btrfs/055.out | 1 +
> >> tests/btrfs/group | 1 +
> >> 3 files changed, 57 insertions(+)
> >> create mode 100755 tests/btrfs/055
> >> create mode 100644 tests/btrfs/055.out
> >>
> >>diff --git a/tests/btrfs/055 b/tests/btrfs/055
> >>new file mode 100755
> >>index 0000000..0a0dd34
> >>--- /dev/null
> >>+++ b/tests/btrfs/055
> >>@@ -0,0 +1,55 @@
> >>+#!/bin/bash
> >>+# FS QA Test No. btrfs/055
> >>+#
> >>+# Regression test for resizing 'thread_pool' when remount the fs.
> >>+#
> IMHO, it would be better to add the commit number for the regression
> and the fix commit number
> (Filipe Manana always does the great job).
>
> For reference:
> Regresssion commit: 08a9ff3264181986d1d692a4e6fce3669700c9f8 (All my fault)
> Fix commit: 800ee2247f483b6d05ed47ef3bbc90b56451746c
That belongs in the commit message, not the test description.
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-12-23 20:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 8:52 [PATCH] btrfs: add regression test for remount with thread_pool resized Xing Gu
2014-06-10 1:27 ` Dave Chinner
2014-09-17 10:02 ` gux.fnst
2014-12-23 7:07 ` Qu Wenruo
2014-12-23 20:47 ` Dave Chinner [this message]
2014-12-23 5:41 ` [PATCH v2] " Xing Gu
2014-12-23 7:23 ` Eryu Guan
2014-12-23 20:56 ` Dave Chinner
2014-12-24 11:38 ` Eryu Guan
2014-12-25 2:00 ` [PATCH v3] " Xing Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223204752.GG4521@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=gux.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).