From: "홍신 shin hong" <hongshin@gmail.com>
To: linux-btrfs@vger.kernel.org
Subject: BUG? a possible race due to the absence of memory barrier
Date: Thu, 12 Nov 2009 00:07:05 +0900 [thread overview]
Message-ID: <2014bcab0911110707i3f2e8782i772603a9b899e353@mail.gmail.com> (raw)
Hello. I am reporting possible data race
due to the the absence of memory barriers.
I reported a similar issue. Although the previous one turns out to be safe,
please examine this issue and let me know your opinion.
In btrfs_init_new_device(), a btrfs_device object is allocated and initialized
and then links to &root->fs_info->fs_devcies->alloc_list.
It seems that a memory barrier is necessary
between the initialization and the linking to the list.
If these two operations are re-ordered so that executed opposite orders,
it may result data race where uninitialized values are read by other threads.
For btrfs_init_new_device(), i think __btfs_alloc_chunk() is a suspected
to be possible to contribute data race by concurrent execution.
Thank you
Sincerely
Shin Hong
next reply other threads:[~2009-11-11 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 15:07 홍신 shin hong [this message]
2009-11-11 16:06 ` BUG? a possible race due to the absence of memory barrier Chris Mason
2009-11-12 1:14 ` 홍신 shin hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2014bcab0911110707i3f2e8782i772603a9b899e353@mail.gmail.com \
--to=hongshin@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox