From: Dave Chinner <david@fromorbit.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: Xing Gu <gux.fnst@cn.fujitsu.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
eguan@redhat.com
Subject: Re: [PATCH v5] btrfs: add regression test for remount with thread_pool resized
Date: Tue, 27 Jan 2015 10:46:54 +1100 [thread overview]
Message-ID: <20150126234654.GB7621@dastard> (raw)
In-Reply-To: <54C6097F.8040600@cn.fujitsu.com>
On Mon, Jan 26, 2015 at 05:31:43PM +0800, Qu Wenruo wrote:
> >+# get standard environment, filters and checks
> >+. ./common/rc
> >+. ./common/filter
> >+
> >+# real QA test starts here
> >+_supported_fs btrfs
> >+_supported_os Linux
> >+_require_scratch
> >+
> >+_scratch_mkfs > /dev/null 2>&1 || _fail "mkfs failed"
> IMHO, it's better to add a new btrfs_mkfs_filter(or something
> similar) to common/filter.btrfs,
> and modify the btrfs case in common/rc:scratch_mkfs() to use the
> filter to wipe the "Performing TRIM"
> line *ONLY*, as other btrfs filters do.
There's already common/filter:_filter_mkfs which has a $FSTYP switch
in it. That's the place to add any btrfs specific mkfs filters,
either in line or as a callout to a special functionin common/btrfs.
Cheers.
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2015-01-26 23:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 8:43 [PATCH v5] btrfs: add regression test for remount with thread_pool resized Xing Gu
2015-01-26 9:31 ` Qu Wenruo
2015-01-26 23:46 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126234654.GB7621@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=gux.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).