From: David Sterba <dsterba@suse.cz>
To: Matt Robinson <git@nerdoftheherd.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.cz>, Mark Fasheh <mfasheh@suse.de>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: Align EOF length to block in extent_same
Date: Wed, 28 Jan 2015 13:55:21 +0100 [thread overview]
Message-ID: <20150128125521.GD3641@twin.jikos.cz> (raw)
In-Reply-To: <1422295551-25402-1-git-send-email-git@nerdoftheherd.com>
On Mon, Jan 26, 2015 at 06:05:51PM +0000, Matt Robinson wrote:
> It is not currently possible to deduplicate the last block of files
> whose size is not a multiple of the block size, as the btrfs_extent_same
> ioctl returns -EINVAL if offset + size is greater than the file size or
> is not aligned to the fs block size.
Do you have a reproducer for that?
The alignment is required to let btrfs_clone and the extent dropping
functions to work. The inline files are not aligned and should not be
deduplicated anyway.
next prev parent reply other threads:[~2015-01-28 20:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 18:05 [PATCH 1/1] btrfs: Align EOF length to block in extent_same Matt Robinson
2015-01-28 12:55 ` David Sterba [this message]
2015-01-28 19:46 ` Matt Robinson
2015-03-02 20:59 ` Matt Robinson
2015-03-03 0:27 ` Zygo Blaxell
2015-04-11 19:17 ` Matt Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128125521.GD3641@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=git@nerdoftheherd.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfasheh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).