From: Mark Fasheh <mfasheh@suse.de>
To: Josef Bacik <jbacik@fb.com>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs: qgroup: fix a wrong parameter of no_quota.
Date: Tue, 3 Mar 2015 12:20:57 -0800 [thread overview]
Message-ID: <20150303202057.GU21790@wotan.suse.de> (raw)
In-Reply-To: <54F5BE84.7090202@fb.com>
On Tue, Mar 03, 2015 at 09:00:36AM -0500, Josef Bacik wrote:
> On 03/03/2015 06:18 AM, Dongsheng Yang wrote:
>> On 02/26/2015 02:05 PM, Dongsheng Yang wrote:
>>> Wait a minute, this patch seems not working well in accounting quota
>>> number when
>>> deleting data shared by different subvolumes.
>>>
>>> I will investigate more about it and send a V2 out.
>> I have sent a fstest
>> [PATCH] fstest: btrfs: add a test for quota number when deleting a
>> subvol.
>> for this problem I was trying to solve in this patch.
>>
>> Please consider reverting the two commits introduced the problem:
>>
>> e339a6b0 (Btrfs: __btrfs_mod_ref should always use no_quota)
>> 1152651a (btrfs: qgroup: account shared subtrees during snapshot delete)
>>
>
> We aren't reverting these two commits, what we had was worse before than it
> is now. We need to figure out why this is resulting in problems and fix
> that rather than throwing out a whole bunch of work. Thanks,
Agreed, reverting these would re-introduce far more problems than it would
solve.
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2015-03-03 20:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 10:24 [PATCH 0/3] Btrfs: qgroup: part-3: bug fixes for deleting subvolume Dongsheng Yang
2015-02-10 10:24 ` [PATCH 1/3] btrfs: qgroup: return EINVAL if level of parent is not higher than child's Dongsheng Yang
2015-02-10 10:24 ` [PATCH 2/3] btrfs: qgroup: allow to remove qgroup which has parent but no child Dongsheng Yang
2015-02-10 10:24 ` [PATCH 3/3] btrfs: qgroup: fix a wrong parameter of no_quota Dongsheng Yang
2015-02-10 11:24 ` Filipe David Manana
2015-02-11 2:51 ` Dongsheng Yang
2015-02-13 9:38 ` Dongsheng Yang
2015-02-26 6:05 ` Dongsheng Yang
2015-03-03 11:13 ` [PATCH] fstest: btrfs: add a test for quota number when deleting a subvol Dongsheng Yang
2015-03-06 5:06 ` Eryu Guan
2015-03-16 5:06 ` Dongsheng Yang
2015-03-16 5:33 ` Eryu Guan
2015-03-16 5:47 ` Dongsheng Yang
2015-03-16 5:58 ` [PATCH v2] " Dongsheng Yang
2015-03-03 11:18 ` [PATCH 3/3] btrfs: qgroup: fix a wrong parameter of no_quota Dongsheng Yang
2015-03-03 14:00 ` Josef Bacik
2015-03-03 20:20 ` Mark Fasheh [this message]
2015-03-16 4:59 ` Dongsheng Yang
2015-03-17 15:27 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303202057.GU21790@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).