From: David Sterba <dsterba@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>, Chris Mason <clm@fb.com>,
bo.li.liu@oracle.com, Eryu Guan <guaneryu@gmail.com>,
linux-btrfs@vger.kernel.org
Subject: Re: btrfs oops while mounting fuzzed btrfs image
Date: Mon, 9 Mar 2015 16:38:41 +0100 [thread overview]
Message-ID: <20150309153841.GF5841@suse.cz> (raw)
In-Reply-To: <20150306100113.GA26485@mew>
On Fri, Mar 06, 2015 at 02:01:13AM -0800, Omar Sandoval wrote:
> +
> + if (ret && btrfs_super_generation(disk_sb) < 10) {
> + printk(KERN_WARNING "btrfs: super block crcs don't match, older mkfs detected\n");
> + ret = 0;
> + }
> I'm not sure that this is exactly what's happening with Eryu's image,
> but it's definitely an issue. I also don't know whether it's safe to get
> rid of that special case. It looks like it's needed for btrfs-progs
> before v3.12 (November 2013). Chris? David?
We might remove the special case in the future. The superblock checks
were enhanced so the low generation number does not let an otherwise
heavily damaged superblock.
next prev parent reply other threads:[~2015-03-09 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 7:09 btrfs oops while mounting fuzzed btrfs image Eryu Guan
2015-03-05 9:46 ` Liu Bo
2015-03-05 10:13 ` Eryu Guan
2015-03-05 10:27 ` Liu Bo
2015-03-06 1:56 ` Qu Wenruo
2015-03-06 10:01 ` Omar Sandoval
2015-03-06 15:46 ` Eric Sandeen
2015-03-09 0:48 ` Qu Wenruo
2015-03-09 15:38 ` David Sterba [this message]
2015-03-05 16:03 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309153841.GF5841@suse.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=clm@fb.com \
--cc=guaneryu@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).