From: David Sterba <dsterba@suse.cz>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Cc: xuw2015@gmail.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: fix btrfs quota rescan failed on PPC64 arch
Date: Fri, 24 Apr 2015 15:42:36 +0200 [thread overview]
Message-ID: <20150424134236.GP4996@twin.jikos.cz> (raw)
In-Reply-To: <4064896.UsZQ5YB6B2@localhost.localdomain>
On Thu, Apr 23, 2015 at 10:43:29PM +0530, Chandan Rajendra wrote:
> On Monday 20 Apr 2015 13:33:16 xuw2015@gmail.com wrote:
> > From: George Wang <xuw2015@gmail.com>
> >
> > PPC64 arch use such following IOC values "
> > \#define _IOC_NONE 1U
> > \#define _IOC_READ 2U
> > \#define _IOC_WRITE 4U
> > " comparing to the default IOC values "
> > \#define _IOC_NONE 0U
> > \#define _IOC_READ 2U
> > \#define _IOC_WRITE 1U"
> >
> > This means the value "_IOW*" will be negative when we store it in the int
> > variables. Such as the "BTRFS_IOC_QGROUP_CREATE", it will be "0x4010942e" on
> > X86_64, but "0x8010942e" on PPC64.
> > Notice that the IOC values are the "unsigned long" type, so we use the
> > "unsigned long" to store it, and this can insure the comparison between the
> > variable and BTRFS_IOC_* valid.
> >
> > Signed-off-by: George Wang <xuw2015@gmail.com>
>
> Tested-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Thanks for testing, commit updated.
prev parent reply other threads:[~2015-04-24 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 5:33 [PATCH] btrfs-progs: fix btrfs quota rescan failed on PPC64 arch xuw2015
2015-04-20 14:47 ` Eric Sandeen
2015-04-21 2:26 ` 王旭
2015-04-22 16:04 ` David Sterba
2015-04-23 17:13 ` Chandan Rajendra
2015-04-24 13:42 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424134236.GP4996@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=chandan@linux.vnet.ibm.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xuw2015@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox