From: Luke Dashjr <luke@dashjr.org>
To: dsterba@suse.cz
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl
Date: Thu, 14 May 2015 16:27:54 +0000 [thread overview]
Message-ID: <201505141627.56205.luke@dashjr.org> (raw)
In-Reply-To: <20150514140617.GY23255@twin.jikos.cz>
On Thursday, May 14, 2015 2:06:17 PM David Sterba wrote:
> On Wed, May 13, 2015 at 05:15:26PM +0000, Luke Dashjr wrote:
> > 32-bit ioctl uses these rather than the regular FS_IOC_* versions. They
> > can be handled in btrfs using the same code. Without this, 32-bit
> > {ch,ls}attr fail.
>
> Yes, but this has to be implemented in another way. See eg.
> https://git.kernel.org/linus/e9750824114ff
I don't see what is different with that implementation. All f2fs_compat_ioctl
does is change cmd to the plain-IOC equivalent and call f2fs_ioctl with the
same arg (compat_ptr merely causes a cast to void* and back, which AFAIK is a
noop on 64-bit?). Am I missing something? I could try to just imitate it, but
I'd rather know what is significant/going on to ensure I don't waste your time
with code I don't even properly understand myself.
Perhaps by coincidence, the patch does at least in practice work (although at
least `btrfs send` appears to be broken still, and I'm at a loss for how to
approach fixing that).
Luke
next prev parent reply other threads:[~2015-05-14 16:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 17:15 [PATCH] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl Luke Dashjr
2015-05-13 17:38 ` Greg KH
2015-05-14 14:06 ` David Sterba
2015-05-14 16:27 ` Luke Dashjr [this message]
2015-05-15 11:19 ` David Sterba
2015-05-15 16:35 ` Luke Dashjr
2015-10-29 8:22 ` Luke Dashjr
2015-10-29 12:05 ` Thomas Rohwer
2015-10-29 15:25 ` David Sterba
2015-10-29 14:39 ` David Sterba
2015-10-29 19:01 ` Luke Dashjr
2015-10-29 19:36 ` Thomas Rohwer
2015-10-29 20:04 ` Luke Dashjr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505141627.56205.luke@dashjr.org \
--to=luke@dashjr.org \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).