From: David Sterba <dsterba@suse.cz>
To: Anthony Plack <anthony@plack.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Additional Debug and other various pr_ additions
Date: Mon, 25 May 2015 14:57:40 +0200 [thread overview]
Message-ID: <20150525125740.GG23255@twin.jikos.cz> (raw)
In-Reply-To: <B6FEFB35-F6C4-41B7-9750-EC400392C0B8@plack.net>
On Sun, May 24, 2015 at 09:42:19PM -0500, Anthony Plack wrote:
> Would I step on anyone’s toes if I started submitting some extra
> patches to increase the verbosity of the BTRFS code in the kernel log?
>
> I would probably start with most things as pr_debug just to keep it
> quiet on non-debug kernels, but I just thought that it might add a
> great deal of clarity to the code base and maybe help sysadmins figure
> out what is a BTRFS issue and what is some other issue.
Starting with pr_debug should be safe. There may be different oppinions
where to put the messages as this can easily fall into "too trivial"
category. This probably needs some "taste" and past experience with
debugging problems to find the good candidate spots in the code. Please
send a sample and let's see.
next prev parent reply other threads:[~2015-05-25 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 2:42 Additional Debug and other various pr_ additions Anthony Plack
2015-05-25 12:57 ` David Sterba [this message]
2015-05-25 14:41 ` [PATCH] Btrfs: Log the error conditions to determine which caused the error in btrfs_init_inode_security Anthony Plack
2015-05-26 13:18 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525125740.GG23255@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anthony@plack.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox