From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH 1/4] btrfs-progs: Minor change of change_uuid().
Date: Tue, 26 May 2015 17:24:12 +0200 [thread overview]
Message-ID: <20150526152411.GL23255@twin.jikos.cz> (raw)
In-Reply-To: <1431671306-22262-1-git-send-email-quwenruo@cn.fujitsu.com>
On Fri, May 15, 2015 at 02:28:23PM +0800, Qu Wenruo wrote:
> Change the change_uuid():
> 1) Remove new_chunk_tree_uuid para
> As chunk_tree_uuid is only internal used, no need to manual specify it.
> Use random generated UUID instead.
>
> 2) Don't use heap allocated memory for fs_info->new_fsid/chunk_tree_id.
> It's easy to forgot free or double free heap memory.
> Use stack memory instead.
> (In fact, I forgot to free them in previous patchset)
>
> 3) Print dst fsid.
> As now it's possible to change fsid to random uuid, it's better to print
> it out.
>
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
All of the patchset applied, thanks!
prev parent reply other threads:[~2015-05-26 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 6:28 [PATCH 1/4] btrfs-progs: Minor change of change_uuid() Qu Wenruo
2015-05-15 6:28 ` [PATCH 2/4] btrfs-progs: Add ability to restore unfinished fsid change Qu Wenruo
2015-05-15 6:28 ` [PATCH 3/4] btrfs-progs: Add '-U' and '-u' option for btrfstune Qu Wenruo
2015-05-15 6:28 ` [PATCH 4/4] btrfs-progs: Update the Document for offline fsid change Qu Wenruo
2015-05-26 15:24 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526152411.GL23255@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).