From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] [PATCH 2/2] Btrfs: fix up read_tree_block to return proper error
Date: Tue, 26 May 2015 18:34:27 +0200 [thread overview]
Message-ID: <20150526163427.GN23255@twin.jikos.cz> (raw)
In-Reply-To: <1432546215-10954-2-git-send-email-bo.li.liu@oracle.com>
On Mon, May 25, 2015 at 05:30:15PM +0800, Liu Bo wrote:
> The return value of read_tree_block() can confuse callers as it always
> returns NULL for either -ENOMEM or -EIO, so it's likely that callers
> parse it to a wrong error, for instance, in btrfs_read_tree_root().
>
> This fixes the above issue.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
next prev parent reply other threads:[~2015-05-26 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 9:30 [PATCH 1/2 RESEND] Btrfs: add missing free_extent_buffer Liu Bo
2015-05-25 9:30 ` [PATCH 2/2] [PATCH 2/2] Btrfs: fix up read_tree_block to return proper error Liu Bo
2015-05-26 16:34 ` David Sterba [this message]
2015-05-26 16:34 ` [PATCH 1/2 RESEND] Btrfs: add missing free_extent_buffer David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526163427.GN23255@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox