From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: dsterba@suse.cz, Facebook <clm@fb.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC] btrfs: csum: Introduce partial csum for tree block.
Date: Thu, 25 Jun 2015 17:31:09 +0200 [thread overview]
Message-ID: <20150625153109.GJ726@twin.jikos.cz> (raw)
In-Reply-To: <55836FB3.1060704@cn.fujitsu.com>
On Fri, Jun 19, 2015 at 09:26:11AM +0800, Qu Wenruo wrote:
> > I agree with that. I'm still not convinced that adding all the kernel
> > code to repair the data is justified, compared to the block-level
> > redundancy alternatives.
>
> Totally agree with this.
> That's why we have support for RAID1/5/6/10.
>
> I also hate to add complexity to kernel codes, especially when the scrub
> codes are already quite complex.
>
> But in fact, my teammate Zhao Lei is already doing some work to make
> scrub codes clean and neat.
Doing cleanups is a good thing regardless of new features, please don't
hesitate to post them even if we do not agree to implement the partial
csum/repair.
I'm not against adding the partial csums & repair, but at the moment I'm
not convinced.
prev parent reply other threads:[~2015-06-25 15:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 3:00 [PATCH RFC] btrfs: csum: Introduce partial csum for tree block Qu Wenruo
2015-06-12 14:10 ` Liu Bo
2015-06-12 16:23 ` Chris Mason
2015-06-15 8:02 ` Qu Wenruo
2015-06-15 13:15 ` David Sterba
2015-06-16 1:22 ` Qu Wenruo
2015-06-16 2:39 ` Qu Wenruo
2015-06-18 1:34 ` Qu Wenruo
2015-06-18 15:57 ` Facebook
2015-06-18 17:06 ` David Sterba
2015-06-19 1:26 ` Qu Wenruo
2015-06-25 15:31 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625153109.GJ726@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox