From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:29911 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753846AbbGBMmb (ORCPT ); Thu, 2 Jul 2015 08:42:31 -0400 Date: Thu, 2 Jul 2015 08:42:21 -0400 From: Chris Mason To: Qu Wenruo CC: Zhaolei , Subject: Re: [PATCH 4/4] btrfs: Fix data checksum error cause by replace with io-load. Message-ID: <20150702124221.GI23627@ret.masoncoding.com> References: <5c5c914dad20c018cfe74174827219c418839f39.1432900529.git.zhaolei@cn.fujitsu.com> <33ad2c0da35681e20afdc6a75ecb19ff2b09f767.1432900529.git.zhaolei@cn.fujitsu.com> <5591FE4A.9060406@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <5591FE4A.9060406@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Jun 30, 2015 at 10:26:18AM +0800, Qu Wenruo wrote: > To Chris: > > Would you consider merging these patchset for late 4.2 merge window? > If it's OK to merge it into 4.2 late rc, we'll start our test and send pull > request after our test, eta this Friday or next Monday. > > I know normally we should submit it early especially when such fix is not > small. > But the bug is long-standing and is quite annoying (possibility involved), > also Zhao Lei has quite a good idea to cleanup the scrub codes based on the > patchset. > > So it would be quite nice if we have any chance to merge it into 4.2 > > Would it be OK for you? > I can still take these patches in a later RC, but with this set applied, I'm getting this during xfstests (btrfs/073 and btrfs/066): [11185.853152] ------------[ cut here ]------------ [11185.862659] WARNING: CPU: 7 PID: 580363 at fs/btrfs/extent-tree.c:9460 btrfs_create_pending_block_groups+0x161/0x1f0 [btrfs]() [11185.885804] Modules linked in: dm_flakey btrfs raid6_pq zlib_deflate lzo_compress xor xfs exportfs libcrc32c tcp_diag inet_diag nfsv4 fuse loop k10temp coretemp hwmon ip6table_filter ip6_tables xt_NFLOG nfnetlink_log nfnetlink xt_comment xt_statistic iptable_filter ip_tables x_tables mptctl nfsv3 nfs lockd grace netconsole autofs4 rpcsec_gss_krb5 auth_rpcgss oid_registry sunrpc ipv6 ext3 jbd iTCO_wdt iTCO_vendor_support pcspkr rtc_cmos ipmi_si ipmi_msghandler i2c_i801 i2c_core lpc_ich mfd_core shpchp ehci_pci ehci_hcd mlx4_en ptp pps_core mlx4_core sg ses enclosure button dm_mod megaraid_sas [11185.994338] CPU: 7 PID: 580363 Comm: btrfs Tainted: G W 4.1.0-rc6-mason+ #82 [11186.011074] Hardware name: ZTSYSTEMS Echo Ridge T4 /A9DRPF-10D, BIOS 1.07 05/10/2012 [11186.027107] 00000000000024f4 ffff880894b539c8 ffffffff816c48c5 ffffffffa06dbe8d [11186.042442] ffff880894b53a18 ffff880894b53a08 ffffffff8105ba75 ffff881053ad4000 [11186.057769] ffff88085417c9a8 ffff88085417c800 ffff8806335a8858 00000000ffffffe5 [11186.073128] Call Trace: [11186.078233] [] dump_stack+0x4f/0x6a [11186.088713] [] warn_slowpath_common+0x95/0xe0 [11186.100926] [] warn_slowpath_fmt+0x46/0x70 [11186.112627] [] btrfs_create_pending_block_groups+0x161/0x1f0 [btrfs] [11186.129039] [] __btrfs_end_transaction+0xac/0x400 [btrfs] [11186.143325] [] btrfs_end_transaction+0x10/0x20 [btrfs] [11186.157092] [] btrfs_inc_block_group_ro+0x116/0x1d0 [btrfs] [11186.171941] [] scrub_enumerate_chunks+0x2f2/0x5e0 [btrfs] [11186.186233] [] ? ttwu_stat+0x4d/0x250 [11186.197045] [] ? bit_waitqueue+0x80/0xa0 [11186.208392] [] ? trace_hardirqs_on+0xd/0x10 [11186.220271] [] btrfs_scrub_dev+0x1c6/0x5d0 [btrfs] [11186.233350] [] ? __mnt_want_write_file+0x29/0x30 [11186.246083] [] btrfs_ioctl_scrub+0xb1/0x130 [btrfs] [11186.259348] [] btrfs_ioctl+0xa68/0x11d0 [btrfs] [11186.271908] [] do_vfs_ioctl+0x8f/0x580 [11186.282903] [] ? __fget+0x110/0x200 [11186.293377] [] ? get_close_on_exec+0x180/0x180 [11186.305764] [] ? __fget_light+0x2a/0x90 [11186.316928] [] SyS_ioctl+0xa1/0xb0 [11186.327233] [] ? __audit_syscall_entry+0xac/0x110 [11186.340133] [] system_call_fastpath+0x12/0x6f [11186.352346] ---[ end trace 720cebad3201fcad ]--- [11186.361785] BTRFS: error (device sdi) in btrfs_create_pending_block_groups:9460: errno=-27 unknown^M I've removed them for now. -chris