From: Mark Fasheh <mfasheh@suse.de>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org, ritter.marcel@gmail.com,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] Btrfs: fix memory leak in the extent_same ioctl
Date: Fri, 3 Jul 2015 09:15:41 -0700 [thread overview]
Message-ID: <20150703161541.GD7507@wotan.suse.de> (raw)
In-Reply-To: <1435909702-2094-1-git-send-email-fdmanana@kernel.org>
That looks great, thanks for fixing this Filipe.
On Fri, Jul 03, 2015 at 08:48:22AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> We were allocating memory with memdup_user() but we were never releasing
> that memory. This affected pretty much every call to the ioctl, whether
> it deduplicated extents or not.
>
> This issue was reported on IRC by Julian Taylor and on the mailing list
> by Marcel Ritter, credit goes to them for finding the issue.
>
> Reported-by: Julian Taylor (jtaylor@IRC)
> Reported-by: Marcel Ritter <ritter.marcel@gmail.com>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>
--Mark
--
Mark Fasheh
prev parent reply other threads:[~2015-07-03 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 7:48 [PATCH] Btrfs: fix memory leak in the extent_same ioctl fdmanana
2015-07-03 10:36 ` [PATCH v2] " fdmanana
2015-07-06 16:57 ` Mark Fasheh
2015-07-03 16:15 ` Mark Fasheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703161541.GD7507@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=ritter.marcel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).