From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:8855 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784AbbGWUWd (ORCPT ); Thu, 23 Jul 2015 16:22:33 -0400 Date: Thu, 23 Jul 2015 16:21:55 -0400 From: Chris Mason To: Qu Wenruo CC: btrfs Subject: Re: [GIT PULL] Fix for btrfs/070 checksum error Message-ID: <20150723202155.GC28964@ret.masoncoding.com> References: <559C9A75.60506@cn.fujitsu.com> <55AF6250.8070602@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <55AF6250.8070602@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, Jul 22, 2015 at 05:28:48PM +0800, Qu Wenruo wrote: > Hi Chris, > > Is there anything wrong with it? > > It has been 2 weeks, and it's still not in your for linus branch. > > Is there anything wrong? I ran this through xfstests again, and got tasks deadlocked during btrfs/061. Looks like scrub is leaking an extent buffer lock? I'll see what I can find, but posting here in case you've seen it already. 155540 (kworker/u65:6) D [] btrfs_tree_lock+0xf0/0x260 [btrfs] [] lock_extent_buffer_for_io+0x1ac/0x1e0 [btrfs] [] btree_write_cache_pages+0x242/0x430 [btrfs] [] btree_writepages+0x6f/0x80 [btrfs] [] do_writepages+0x23/0x40 [] __writeback_single_inode+0x7d/0x780 [] writeback_sb_inodes+0x2b1/0x570 [] wb_writeback+0x136/0x760 [] wb_do_writeback+0x110/0x440 [] wb_workfn+0x95/0x440 [] process_one_work+0x1e8/0x730 [] worker_thread+0x11a/0x4d0 [] kthread+0xe9/0x110 [] ret_from_fork+0x3f/0x70 [] 0xffffffffffffffff 240994 (btrfs-transacti) D [] wait_for_commit+0x59/0x90 [btrfs] [] btrfs_commit_transaction+0x284/0xd10 [btrfs] [] transaction_kthread+0x246/0x2a0 [btrfs] [] kthread+0xe9/0x110 [] ret_from_fork+0x3f/0x70 [] 0xffffffffffffffff 241000 (btrfs) D [] btrfs_tree_lock+0xf0/0x260 [btrfs] [] lock_extent_buffer_for_io+0x1ac/0x1e0 [btrfs] [] btree_write_cache_pages+0x242/0x430 [btrfs] [] btree_writepages+0x6f/0x80 [btrfs] [] do_writepages+0x23/0x40 [] __filemap_fdatawrite_range+0xb5/0x100 [] filemap_fdatawrite_range+0x13/0x20 [] btrfs_write_marked_extents+0xf4/0x140 [btrfs] [] btrfs_write_and_wait_transaction+0x4b/0x90 [btrfs] [] btrfs_commit_transaction+0x8b5/0xd10 [btrfs] [] relocate_block_group+0x41e/0x5e0 [btrfs] [] btrfs_relocate_block_group+0x184/0x2a0 [btrfs] [] btrfs_relocate_chunk+0x7a/0x110 [btrfs] [] btrfs_balance+0x9bc/0x1060 [btrfs] [] btrfs_ioctl_balance+0x1c8/0x330 [btrfs] [] btrfs_ioctl+0x409/0x1150 [btrfs] [] do_vfs_ioctl+0x8a/0x570 [] SyS_ioctl+0x92/0xa0 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241024 (btrfs) D [] __scrub_blocked_if_needed+0x7e/0xc0 [btrfs] [] scrub_pause_off+0x32/0x70 [btrfs] [] scrub_enumerate_chunks+0x4d3/0x5d0 [btrfs] [] btrfs_scrub_dev+0x1c6/0x5a0 [btrfs] [] btrfs_ioctl_scrub+0xb1/0x120 [btrfs] [] btrfs_ioctl+0xa03/0x1150 [btrfs] [] do_vfs_ioctl+0x8a/0x570 [] SyS_ioctl+0x92/0xa0 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241002 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241003 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241004 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241005 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241006 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241007 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241008 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241009 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241010 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241012 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241013 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241015 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241016 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241019 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241020 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 241021 (fsstress) D [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff 16 hits: [] wb_wait_for_completion+0x5f/0x90 [] sync_inodes_sb+0x99/0x1c0 [] sync_inodes_one_sb+0x16/0x20 [] iterate_supers+0xaf/0xe0 [] sys_sync+0x35/0x90 [] entry_SYSCALL_64_fastpath+0x12/0x6f [] 0xffffffffffffffff -----