From: Omar Sandoval <osandov@fb.com>
To: <dsterba@suse.com>, <fstests@vger.kernel.org>,
<linux-btrfs@vger.kernel.org>,
Wang Yanfeng <wangyf-fnst@cn.fujitsu.com>
Subject: Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs
Date: Fri, 24 Jul 2015 10:50:43 -0700 [thread overview]
Message-ID: <20150724175043.GA14974@huxley.DHCP.TheFacebook.com> (raw)
In-Reply-To: <20150724120946.GT6306@twin.jikos.cz>
On Fri, Jul 24, 2015 at 02:09:46PM +0200, David Sterba wrote:
> On Thu, Jul 23, 2015 at 01:51:50PM -0700, Omar Sandoval wrote:
> > + # We can't do replace with these profiles because they
> > + # imply only one device ($SCRATCH_DEV), and we need to
> > + # keep $SCRATCH_DEV around for _scratch_mount
> > + # and _check_scratch_fs.
> > + local unsupported=(
> > + "single"
> > + "dup"
>
> DUP does imply single device, but why does 'single' ?
It does not, I apparently forgot that you could use single to
concatenate multiple devices. I'll fix that in v2.
Thanks for reviewing!
--
Omar
next prev parent reply other threads:[~2015-07-24 17:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 20:51 [PATCH 0/3] xfstests: test btrfs replace on RAID 5/6 Omar Sandoval
2015-07-23 20:51 ` [PATCH 1/3] btrfs/011: test replace on RAID 5/6 now that it's supported Omar Sandoval
2015-07-24 3:01 ` Eryu Guan
2015-07-24 12:10 ` David Sterba
2015-07-23 20:51 ` [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs Omar Sandoval
2015-07-24 3:03 ` Eryu Guan
2015-07-24 12:09 ` David Sterba
2015-07-24 17:50 ` Omar Sandoval [this message]
2015-07-27 22:22 ` Brendan Hide
2015-07-27 22:44 ` Hugo Mills
2015-07-28 16:52 ` David Sterba
2015-07-28 17:41 ` Omar Sandoval
2015-07-23 20:51 ` [PATCH 3/3] btrfs: add a test of replace missing dev in diff raid Omar Sandoval
2015-07-24 3:28 ` Eryu Guan
2015-07-24 17:52 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724175043.GA14974@huxley.DHCP.TheFacebook.com \
--to=osandov@fb.com \
--cc=dsterba@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangyf-fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).