From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:37417 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbG1QwU (ORCPT ); Tue, 28 Jul 2015 12:52:20 -0400 Date: Tue, 28 Jul 2015 18:52:07 +0200 From: David Sterba To: Brendan Hide Cc: Wang Yanfeng , Omar Sandoval , fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/3] btrfs: add replace missing and replace RAID 5/6 to profile configs Message-ID: <20150728165207.GK6306@suse.cz> Reply-To: dsterba@suse.com References: <6d332e954da29e8418689cb49294a68da2fa5376.1437683940.git.osandov@fb.com> <20150724120946.GT6306@twin.jikos.cz> <20150724175043.GA14974@huxley.DHCP.TheFacebook.com> <55B6AF40.5040107@swiftspirit.co.za> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <55B6AF40.5040107@swiftspirit.co.za> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Jul 28, 2015 at 12:22:56AM +0200, Brendan Hide wrote: > > It does not, I apparently forgot that you could use single to > > concatenate multiple devices. I'll fix that in v2. > > > > Thanks for reviewing! > > > Late to the party. DUP *implies* single device but there are cases > where dup is used on a multi-device fs. Even if the use-cases aren't > good or intended to be long-term, they are still valid, right? You're right, DUP is reported by 'fi df' after 2nd device is added and this state (even if it's temporary) has to be taken into account.