From: Liu Bo <bo.li.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: btrfs regression test for defrag tail extents
Date: Thu, 13 Aug 2015 11:22:04 +0800 [thread overview]
Message-ID: <20150813032203.GB920@localhost.localdomain> (raw)
In-Reply-To: <20150811023201.GL3902@dastard>
On Tue, Aug 11, 2015 at 12:32:01PM +1000, Dave Chinner wrote:
> On Mon, Aug 10, 2015 at 04:12:59PM +0800, Liu Bo wrote:
> > Regression test for btrfs defragment tool, it's aimed to verify
> > that tail extents won't be skipped as a separate extent while the previous
> > extents have been defrag'ed into a whole extent.
> >
> > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
>
> I don't see anything btrfs specific in this test, so it belongs in
> tests/generic/
>
> Also, how is this different to generic/018 testing fragmented files
> defrag back to one extent?
Thanks for reminding me of this, it's in fact quite similar to one of
the cases in generic/018, and the difference is that btrfs has an extent
length thresh (256K) for deciding if the extent is big enough (no need to defrag).
That said, I'd like to add this into generic/018 to keep it simple.
Thanks,
-liubo
next prev parent reply other threads:[~2015-08-13 3:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 8:12 [PATCH] fstests: btrfs regression test for defrag tail extents Liu Bo
2015-08-10 9:17 ` Filipe David Manana
2015-08-13 3:15 ` Liu Bo
2015-08-11 2:32 ` Dave Chinner
2015-08-13 3:22 ` Liu Bo [this message]
2015-08-13 8:44 ` [PATCH] fstests: generic/018: expend "write backwards sync but contiguous" to test regression in btrfs Liu Bo
2015-08-13 8:47 ` [PATCH v2] fstests: generic/018: expand " Liu Bo
2015-08-13 9:43 ` Filipe David Manana
2015-08-13 9:44 ` Filipe David Manana
2015-08-14 15:19 ` Eric Sandeen
2015-08-16 23:27 ` Dave Chinner
2015-08-19 2:50 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813032203.GB920@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).