From: Dave Chinner <david@fromorbit.com>
To: anand jain <anand.jain@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
eguan@redhat.com, fdmanana@gmail.com
Subject: Re: [PATCH v6 1/3] xfstests: btrfs: add functions to create dm-error device
Date: Wed, 19 Aug 2015 16:45:29 +1000 [thread overview]
Message-ID: <20150819064529.GJ3902@dastard> (raw)
In-Reply-To: <55D3F4FA.6080309@oracle.com>
On Wed, Aug 19, 2015 at 11:16:10AM +0800, anand jain wrote:
>
>
> >Ok, SCRATCH_OPTIONS might not be the best idea here, so feel free to
> >drop it.
>
> I have dropped $SCRATCH_OPTIONS. (waiting to submit v8). Thanks.
>
> >However, you've still missed the primary reason I suggested
> >_scratch_mount_options in the first place:
>
> I am shocked. What was missed ?
Answering the question I asked:
Q: "what do we do instead of copy'n'paste of random code fragments?"
Think on it, because the answer to that question (and it's not a
hard one) should tell you exactly what you need to do.
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-08-19 6:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 10:47 [PATCH v5 0/3] dm error based test cases Anand Jain
2015-08-14 10:47 ` [PATCH v5 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-08-14 11:03 ` Eryu Guan
2015-08-14 10:47 ` [PATCH v5 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-08-14 11:07 ` Eryu Guan
2015-08-14 11:14 ` Filipe David Manana
2015-08-14 10:47 ` [PATCH v5 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
2015-08-14 11:09 ` Eryu Guan
2015-08-14 15:31 ` [PATCH v6 0/3] dm error based test cases Anand Jain
2015-08-14 15:31 ` [PATCH v6 1/3] xfstests: btrfs: add functions to create dm-error device Anand Jain
2015-08-16 23:52 ` Dave Chinner
2015-08-18 4:26 ` anand jain
2015-08-18 22:11 ` Dave Chinner
2015-08-19 3:16 ` anand jain
2015-08-19 6:45 ` Dave Chinner [this message]
2015-08-20 7:09 ` Anand Jain
2015-08-20 21:45 ` Dave Chinner
2015-08-25 4:40 ` Anand Jain
2015-08-14 15:31 ` [PATCH v6 2/3] xfstests: btrfs: test device replace, with EIO on the src dev Anand Jain
2015-08-14 15:31 ` [PATCH v6 3/3] xfstests: btrfs: test device delete with EIO on " Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819064529.GJ3902@dastard \
--to=david@fromorbit.com \
--cc=anand.jain@oracle.com \
--cc=eguan@redhat.com \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).