From: Dave Chinner <david@fromorbit.com>
To: Peng Tao <tao.peng@primarydata.com>
Cc: linux-nfs@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Christoph Hellwig <hch@infradead.org>, Zach Brown <zab@zabbo.net>,
Darren Hart <dvhart@linux.intel.com>,
bfields@fieldses.org, Jeff Layton <jeff.layton@primarydata.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 01/11] vfs: pull btrfs clone API to vfs layer
Date: Wed, 26 Aug 2015 11:50:34 +1000 [thread overview]
Message-ID: <20150826015034.GY3902@dastard> (raw)
In-Reply-To: <1440516829-116041-2-git-send-email-tao.peng@primarydata.com>
On Tue, Aug 25, 2015 at 11:33:39PM +0800, Peng Tao wrote:
> Now that a few file systems are adding clone functionality, namingly
> btrfs, NFS (later in the series) and XFS
> (ttp://oss.sgi.com/archives/xfs/2015-06/msg00407.html), it makes sense
> to pull the ioctl to common code.
>
> Add vfs_file_clone_range() helper and .clone_range file operation interface
> to allow underlying filesystems to clone between regular files.
>
> The change in do_vfs_ioctl() is defered to next patch where btrfs
> .clone_range is added, just so that we don't break btrfs CLONE ioctl
> with this patch.
>
> Cc: linux-btrfs@vger.kernel.org
> Cc: linux-fsdevel@vger.kernel.org
Can you please cc the entire patch series to linux-fsdevel?
Spraying random patches from a larger series to different lists is
not very nice - I can't really comment on this patch because I have
no idea what context it is being proposed in, what the problem being
solved is, how it is being used by existing filesystems, how it will
be used by your new changes, etc.
You may have explained all this in patch 0 for the series, but
that hasn't been cc'd to linux-fsdevel....
Cheers,
Dave.
PS: CC list spraying also plays badly with dup filters and per-list
procmail sorting that a lot of people use to manage incoming
feeds....
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-08-26 1:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440516829-116041-1-git-send-email-tao.peng@primarydata.com>
2015-08-25 15:33 ` [PATCH RFC 01/11] vfs: pull btrfs clone API to vfs layer Peng Tao
2015-08-26 1:40 ` Peng Tao
2015-08-26 1:50 ` Dave Chinner [this message]
2015-08-26 1:59 ` Dave Chinner
2015-08-26 4:09 ` Darrick J. Wong
2015-08-26 8:03 ` Peng Tao
2015-08-25 15:33 ` [PATCH RFC 02/11] vfs/btrfs: add .clone_range file operation Peng Tao
2015-08-26 8:01 ` David Sterba
2015-08-26 8:31 ` Peng Tao
2015-08-26 13:00 ` David Sterba
2015-08-26 13:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826015034.GY3902@dastard \
--to=david@fromorbit.com \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=dvhart@linux.intel.com \
--cc=hch@infradead.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@primarydata.com \
--cc=trond.myklebust@primarydata.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).