Re: [PATCH v2 0/9] free space B-tree

[Omar Sandoval <osandov@osandov.com>]

On Fri, Sep 04, 2015 at 09:29:45AM +0800, Zhao Lei wrote:
> Hi, Omar Sandoval
> 
> [PATCH 7/9] have following compiler warning:
>  fs/btrfs/tests/free-space-tree-tests.c: In function '__check_free_space_extents':   
>  fs/btrfs/tests/free-space-tree-tests.c:45: warning: 'offset' may be used uninitialized in this function   
> 
> It is just a compiler warning, and will not happened in code logic,
> but could you fix it to make output pretty?
> 
> Thanks
> Zhaolei

Thanks, Zhaolei, I actually meant to use "end" where I used "offset" on
line 94, that should get rid of the warning and be more correct. I'll
fix it and send it out in v3.

Omar

> 
> * From: linux-btrfs-owner@vger.kernel.org
> > [mailto:linux-btrfs-owner@vger.kernel.org] On Behalf Of Omar Sandoval
> > Sent: Friday, September 04, 2015 3:44 AM
> > To: linux-btrfs@vger.kernel.org
> > Cc: Omar Sandoval <osandov@osandov.com>
> > Subject: [PATCH v2 0/9] free space B-tree
> > 
> > Here's version 2 of the the free space B-tree patches, addressing Josef's review
> > from the last round, which you can find here:
> > http://www.spinics.net/lists/linux-btrfs/msg46713.html
> > 
> > Changes from v1->v2:
> > 
> > - Cleaned up a bunch of unnecessary instances of "if (ret) goto out; ret = 0"
> > - Added aborts in the free space tree code closer to the site the error
> >   is encountered: where we add or remove block groups, add or remove
> >   free space, and also when we convert formats
> > - Moved loading of the free space tree into caching_thread() and added a
> >   new patch 4 in preparation for it
> > - Commented a bunch of stuff in the extent buffer bitmap operations and
> >   refactored some of the complicated logic
> > - Added sanity tests for the extent buffer bitmap operations and free
> >   space tree (patches 2 and 6)
> > - Added Josef's Reviewed-by tags
> > 
> > Omar Sandoval (9):
> >   Btrfs: add extent buffer bitmap operations
> >   Btrfs: add extent buffer bitmap sanity tests
> >   Btrfs: add helpers for read-only compat bits
> >   Btrfs: refactor caching_thread()
> >   Btrfs: introduce the free space B-tree on-disk format
> >   Btrfs: implement the free space B-tree
> >   Btrfs: add free space tree sanity tests
> >   Btrfs: wire up the free space tree to the extent tree
> >   Btrfs: add free space tree mount option
> > 
> >  fs/btrfs/Makefile                      |    5 +-
> >  fs/btrfs/ctree.h                       |  107 ++-
> >  fs/btrfs/disk-io.c                     |   26 +
> >  fs/btrfs/extent-tree.c                 |  112 ++-
> >  fs/btrfs/extent_io.c                   |  183 +++-
> >  fs/btrfs/extent_io.h                   |   10 +-
> >  fs/btrfs/free-space-tree.c             | 1501
> > ++++++++++++++++++++++++++++++++
> >  fs/btrfs/free-space-tree.h             |   71 ++
> >  fs/btrfs/super.c                       |   24 +-
> >  fs/btrfs/tests/btrfs-tests.c           |   52 ++
> >  fs/btrfs/tests/btrfs-tests.h           |   10 +
> >  fs/btrfs/tests/extent-io-tests.c       |  138 ++-
> >  fs/btrfs/tests/free-space-tests.c      |   35 +-
> >  fs/btrfs/tests/free-space-tree-tests.c |  570 ++++++++++++
> >  fs/btrfs/tests/qgroup-tests.c          |   20 +-
> >  include/trace/events/btrfs.h           |    3 +-
> >  16 files changed, 2763 insertions(+), 104 deletions(-)  create mode 100644
> > fs/btrfs/free-space-tree.c  create mode 100644 fs/btrfs/free-space-tree.h
> > create mode 100644 fs/btrfs/tests/free-space-tree-tests.c
> > 
> > --
> > 2.5.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body
> > of a message to majordomo@vger.kernel.org More majordomo info at
> > http://vger.kernel.org/majordomo-info.html
> 

-- 
Omar