From: Dave Chinner <david@fromorbit.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v6] fstests: btrfs: Add reserved space leak check for rewrite dirty page
Date: Mon, 21 Sep 2015 10:29:44 +1000 [thread overview]
Message-ID: <20150921002944.GJ26895@dastard> (raw)
In-Reply-To: <1440574257-1544-1-git-send-email-quwenruo@cn.fujitsu.com>
On Wed, Aug 26, 2015 at 03:30:57PM +0800, Qu Wenruo wrote:
> +# Use big blocksize to ensure there is still enough space left for metadata
> +# space reserve.
> +BLOCKSIZE=$(( 2 * 1024 * 1024 )) # 2M block size
> +FILESIZE=$(( 128 * 1024 * 1024 )) # 128M file size
Little thing in terms of style here: global variables that come from
the test harness use upper case, local test variabled should use
lowercase. It just makes it easy to see what variables have come
from the environment/test harness versus those that are used only by
the test.
I'll change this when I commit the patch....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2015-09-21 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 7:30 [PATCH v6] fstests: btrfs: Add reserved space leak check for rewrite dirty page Qu Wenruo
2015-09-21 0:29 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921002944.GJ26895@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).