From: David Sterba <dsterba@suse.cz>
To: Alexandru Moise <00moses.alexander00@gmail.com>
Cc: clm@fb.com, jbacik@fb.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: avoid passing int param to start_transaction which takes u64
Date: Tue, 22 Sep 2015 15:43:40 +0200 [thread overview]
Message-ID: <20150922134340.GF12815@suse.cz> (raw)
In-Reply-To: <20150922133307.GA2369@gmail.com>
On Tue, Sep 22, 2015 at 04:33:07PM +0300, Alexandru Moise wrote:
> > I think it's better to do it the other way around, ie. let all the
> > equivalents of 'num_items' be an int. We know that this is a small
> > number, using u64 for that is an overkill. As the number is always
> > positive, please make it 'unsigned'.
>
> So you'd want it to be "unsigned int" or "u32"?
'unsigned int' please
next prev parent reply other threads:[~2015-09-22 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 18:47 [PATCH 1/2] btrfs: avoid passing int param to start_transaction which takes u64 Alexandru Moise
2015-09-22 13:09 ` David Sterba
2015-09-22 13:33 ` Alexandru Moise
2015-09-22 13:43 ` David Sterba [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-13 14:29 Alexandru Moise
[not found] ` <pan.2015.09.13.14.53.14@googlemail.com>
2015-09-13 18:34 ` Alexandru Moise
2015-09-13 18:50 ` Alexandru Moise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922134340.GF12815@suse.cz \
--to=dsterba@suse.cz \
--cc=00moses.alexander00@gmail.com \
--cc=clm@fb.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).