* [PATCH] btrfs: remove unneeded NULL initializer for struct fs_path
@ 2015-09-26 12:05 Alexandru Moise
2015-09-29 12:32 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Alexandru Moise @ 2015-09-26 12:05 UTC (permalink / raw)
To: clm; +Cc: jbacik, dsterba, linux-btrfs, linux-kernel, 00moses.alexander00
fs_path_alloc() either returns an alloc'ed struct fs_path
or NULL, no need to initialize the pointer to NULL.
Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
---
fs/btrfs/send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index aa72bfd..0019c90 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -2230,7 +2230,7 @@ static int get_cur_path(struct send_ctx *sctx, u64 ino, u64 gen,
struct fs_path *dest)
{
int ret = 0;
- struct fs_path *name = NULL;
+ struct fs_path *name;
u64 parent_inode = 0;
u64 parent_gen = 0;
int stop = 0;
--
2.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unneeded NULL initializer for struct fs_path
2015-09-26 12:05 [PATCH] btrfs: remove unneeded NULL initializer for struct fs_path Alexandru Moise
@ 2015-09-29 12:32 ` David Sterba
2015-09-29 19:33 ` Alexandru Moise
0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2015-09-29 12:32 UTC (permalink / raw)
To: Alexandru Moise; +Cc: clm, jbacik, dsterba, linux-btrfs, linux-kernel
On Sat, Sep 26, 2015 at 12:05:19PM +0000, Alexandru Moise wrote:
> fs_path_alloc() either returns an alloc'ed struct fs_path
> or NULL, no need to initialize the pointer to NULL.
>
> Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
> ---
> fs/btrfs/send.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index aa72bfd..0019c90 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -2230,7 +2230,7 @@ static int get_cur_path(struct send_ctx *sctx, u64 ino, u64 gen,
> struct fs_path *dest)
> {
> int ret = 0;
> - struct fs_path *name = NULL;
> + struct fs_path *name;
I'd rather see all such instances fixed in one patch. Quick grep
revealed a few more. OTOH this kind of extra initialization is harmless
and sometimes help readability, it's clear that he value is zeroed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: remove unneeded NULL initializer for struct fs_path
2015-09-29 12:32 ` David Sterba
@ 2015-09-29 19:33 ` Alexandru Moise
0 siblings, 0 replies; 3+ messages in thread
From: Alexandru Moise @ 2015-09-29 19:33 UTC (permalink / raw)
To: David Sterba; +Cc: clm, jbacik, linux-btrfs, linux-kernel
On Tue, Sep 29, 2015 at 02:32:29PM +0200, David Sterba wrote:
> On Sat, Sep 26, 2015 at 12:05:19PM +0000, Alexandru Moise wrote:
> > fs_path_alloc() either returns an alloc'ed struct fs_path
> > or NULL, no need to initialize the pointer to NULL.
> >
> > Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
> > ---
> > fs/btrfs/send.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> > index aa72bfd..0019c90 100644
> > --- a/fs/btrfs/send.c
> > +++ b/fs/btrfs/send.c
> > @@ -2230,7 +2230,7 @@ static int get_cur_path(struct send_ctx *sctx, u64 ino, u64 gen,
> > struct fs_path *dest)
> > {
> > int ret = 0;
> > - struct fs_path *name = NULL;
> > + struct fs_path *name;
>
> I'd rather see all such instances fixed in one patch. Quick grep
> revealed a few more. OTOH this kind of extra initialization is harmless
> and sometimes help readability, it's clear that he value is zeroed.
When you put it like that, you are right, it's more important to make
things obvious than to fiercely abide by all the subtleties of our
coding style. I submit to your point of view and will not insist on
this kind of change in the future.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-29 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-26 12:05 [PATCH] btrfs: remove unneeded NULL initializer for struct fs_path Alexandru Moise
2015-09-29 12:32 ` David Sterba
2015-09-29 19:33 ` Alexandru Moise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).