From: Omar Sandoval <osandov@osandov.com>
To: Josef Bacik <jbacik@fb.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH V2] Btrfs: end transaction if we abort when creating qgroup root
Date: Sat, 26 Sep 2015 17:54:11 -0700 [thread overview]
Message-ID: <20150927005411.GA3213@mew> (raw)
In-Reply-To: <1443034837-1723-1-git-send-email-jbacik@fb.com>
On Wed, Sep 23, 2015 at 03:00:37PM -0400, Josef Bacik wrote:
> We still need to call btrfs_end_transaction if we call btrfs_abort_transaction,
> otherwise we hang and make me super grumpy. Thanks,
I made the same mistake in the free space tree, I'll fix that before I
forget.
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
> V1->V2: should have compiled before I hit send.
>
> fs/btrfs/volumes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index fbe7c10..ff64689 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -4028,6 +4028,7 @@ int btrfs_create_uuid_tree(struct btrfs_fs_info *fs_info)
The subject says the qgroup root but this is the uuid tree.
> if (IS_ERR(uuid_root)) {
> ret = PTR_ERR(uuid_root);
> btrfs_abort_transaction(trans, tree_root, ret);
> + btrfs_end_transaction(trans, tree_root);
> return ret;
> }
>
> --
> 1.8.3.1
--
Omar
prev parent reply other threads:[~2015-09-27 0:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 18:56 [PATCH] Btrfs: end transaction if we abort when creating qgroup root Josef Bacik
2015-09-23 19:00 ` [PATCH V2] " Josef Bacik
2015-09-27 0:54 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150927005411.GA3213@mew \
--to=osandov@osandov.com \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).