linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hugo Mills <hugo@carfax.org.uk>
To: Austin S Hemmelgarn <ahferroin7@gmail.com>
Cc: dsterba@suse.cz, "Gabríel Arthúr Pétursson" <gabriel@system.is>,
	linux-btrfs@vger.kernel.org
Subject: Re: Add stripes filter
Date: Tue, 29 Sep 2015 12:21:39 +0000	[thread overview]
Message-ID: <20150929122139.GF25907@carfax.org.uk> (raw)
In-Reply-To: <560A7FAB.1040607@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1790 bytes --]

On Tue, Sep 29, 2015 at 08:10:19AM -0400, Austin S Hemmelgarn wrote:
> On 2015-09-29 08:00, David Sterba wrote:
> >On Mon, Sep 28, 2015 at 05:57:05PM +0000, Gabríel Arthúr Pétursson wrote:
> >>The attached patches to linux and btrfs-progs add support for filtering
> >>based on the number of strips in a block when balancing.
> >
> >What usecase do you want to address? As I understand it, this would help
> >the raid56 rebalancing to process only blockgroups that are not spread
> >accross enough devices.

   Exactly. Last week, I was trying to help Gabríel on IRC with a
close-to-full filesystem balance it to add some new devices in a
parity RAID configuration. He'd added the devices and balanced, but
the usage was unequal across the devices. The only way I could think
of dealing with it with the current tools was either to do a full
balance repeatedly until it worked itself out, or to delve into the
metadata with btrfs-debug-tree, and balance selected block groups
individually.

   I whinged that we needed a filter to pick just the block groups
that weren't "as full as possible", and Gabríel picked up the idea and
ran with it.

> This could also be helpful when reshaping a raid10 or raid0 setup.

   Yes, although ultimately less important in most cases, I think,
because you don't lose space by reducing the number of devices in a
block group for those. There are some corner cases where you could end
up losing space by having one (for RAID-0) or up to three (for
RAID-10) devices with more space left than the rest.

   Hugo.

-- 
Hugo Mills             | Dullest spy film ever: The Eastbourne Ultimatum
hugo@... carfax.org.uk |
http://carfax.org.uk/  |
PGP: E2AB1DE4          |                                       The Thick of It

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2015-09-29 12:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 17:57 Add stripes filter Gabríel Arthúr Pétursson
2015-09-28 21:11 ` Omar Sandoval
2015-09-28 22:32 ` [PATCH] btrfs: add " Gabríel Arthúr Pétursson
2015-09-30 15:50   ` David Sterba
2015-09-28 22:33 ` [PATCH] btrfs-progs: " Gabríel Arthúr Pétursson
2015-09-29 12:00 ` Add " David Sterba
2015-09-29 12:10   ` Austin S Hemmelgarn
2015-09-29 12:21     ` Hugo Mills [this message]
2015-09-30 15:28       ` David Sterba
2015-09-30 15:16     ` David Sterba
2015-10-12 14:10 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929122139.GF25907@carfax.org.uk \
    --to=hugo@carfax.org.uk \
    --cc=ahferroin7@gmail.com \
    --cc=dsterba@suse.cz \
    --cc=gabriel@system.is \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).