From: David Sterba <dsterba@suse.cz>
To: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: mkfs: Enable -d dup for single device
Date: Tue, 27 Oct 2015 15:20:11 +0100 [thread overview]
Message-ID: <20151027142011.GT13624@twin.jikos.cz> (raw)
In-Reply-To: <fff170b03b5707d4b4457f36da271fadf4bdeade.1444732174.git.zhaolei@cn.fujitsu.com>
On Tue, Oct 13, 2015 at 06:29:41PM +0800, Zhao Lei wrote:
> Current code don't support dup profile in single device, except it
> is in mixed mode, because following reason:
> 1: In some ssd with deduplication function, it have no effect.
> 2: For a physical device, it the entire disk broken, -d dup can
> not help.
> 3: Half performance comparing with single profile.
> 4: We have a workaround: Create multi-partition in single device,
> and btefs will treat them as multi device.
>
> Instead of refuse -d dup, we have a better choise:
> Give user a chance to select, and output a warning to notice above
> problem.
>
> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
FYI, I've queued the patch for 4.4 (or later) whenever we're ready on
the kernel side.
next prev parent reply other threads:[~2015-10-27 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 10:29 [PATCH] btrfs-progs: mkfs: Enable -d dup for single device Zhao Lei
2015-10-13 11:28 ` David Sterba
2015-10-13 11:40 ` Zhao Lei
2015-10-13 12:36 ` David Sterba
2015-10-13 13:13 ` Zhao Lei
2015-10-27 14:20 ` David Sterba [this message]
2015-10-28 1:41 ` Zhao Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027142011.GT13624@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).