From: Dan Carpenter <dan.carpenter@oracle.com>
To: dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org
Subject: re: btrfs: extend balance filter usage to take minimum and maximum
Date: Thu, 12 Nov 2015 12:36:07 +0300 [thread overview]
Message-ID: <20151112093607.GA28337@mwanda> (raw)
Hello David Sterba,
The patch bc3094673f22: "btrfs: extend balance filter usage to take
minimum and maximum" from Oct 20, 2015, leads to the following static
checker warning:
fs/btrfs/volumes.c:3063 update_balance_args()
warn: we tested 'bctl->data.flags & (1 << 8)' before and it was 'false'
fs/btrfs/volumes.c
3054 /*
3055 * Turn on usage filter if is not already used. The idea is
3056 * that chunks that we have already balanced should be
3057 * reasonably full. Don't do it for chunks that are being
3058 * converted - that will keep us from relocating unconverted
3059 * (albeit full) chunks.
3060 */
3061 if (!(bctl->data.flags & BTRFS_BALANCE_ARGS_USAGE) &&
3062 !(bctl->data.flags & BTRFS_BALANCE_ARGS_USAGE_RANGE) &&
3063 !(bctl->data.flags & BTRFS_BALANCE_ARGS_CONVERT)) {
USAGE_RANGE and ARGS_CONVERT are both BIT(8) so this is duplicative.
3064 bctl->data.flags |= BTRFS_BALANCE_ARGS_USAGE;
3065 bctl->data.usage = 90;
3066 }
3067 if (!(bctl->sys.flags & BTRFS_BALANCE_ARGS_USAGE) &&
3068 !(bctl->sys.flags & BTRFS_BALANCE_ARGS_USAGE_RANGE) &&
3069 !(bctl->sys.flags & BTRFS_BALANCE_ARGS_CONVERT)) {
Same.
3070 bctl->sys.flags |= BTRFS_BALANCE_ARGS_USAGE;
3071 bctl->sys.usage = 90;
3072 }
3073 if (!(bctl->meta.flags & BTRFS_BALANCE_ARGS_USAGE) &&
3074 !(bctl->meta.flags & BTRFS_BALANCE_ARGS_USAGE_RANGE) &&
3075 !(bctl->meta.flags & BTRFS_BALANCE_ARGS_CONVERT)) {
Same.
3076 bctl->meta.flags |= BTRFS_BALANCE_ARGS_USAGE;
3077 bctl->meta.usage = 90;
3078 }
3079 }
regards,
dan carpenter
reply other threads:[~2015-11-12 9:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112093607.GA28337@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox