Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>,
	"Stefan Priebe - Profihost AG" <s.priebe@profihost.ag>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: Regression in btrfs: properly set the termination value of ctx->pos in readdir
Date: Thu, 12 Nov 2015 14:09:01 +0100	[thread overview]
Message-ID: <20151112130901.GJ6445@suse.cz> (raw)
In-Reply-To: <20151112103523.GI6445@twin.jikos.cz>

On Thu, Nov 12, 2015 at 11:35:23AM +0100, David Sterba wrote:
> On Wed, Nov 11, 2015 at 01:22:19PM +0100, Holger Hoffstätte wrote:
> > > the patch btrfs: properly set the termination value of ctx->pos in
> > > readdir introduces a regression to me.
> > >
> > > A lot of stuff runs in "endless" or long running loops.
> > 
> > Just tested this and can confirm something is off.
> > In a directory with several files, create a new directory and move all
> > files into the new subdir.
> > 
> > An immediately following ls will hang. The problem goes away after a
> > manual sync.
> 
> I can reproduce the hang, thanks.

The hang was triggered by use of trace_printk and I'm seeing several
strange bugs caused by added debugging, so I can't say I can reproduce
it yet.

  reply	other threads:[~2015-11-12 13:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 11:57 Regression in btrfs: properly set the termination value of ctx->pos in readdir Stefan Priebe - Profihost AG
2015-11-11 12:22 ` Holger Hoffstätte
2015-11-12 10:35   ` David Sterba
2015-11-12 13:09     ` David Sterba [this message]
2015-11-12 13:17       ` Holger Hoffstätte
2015-11-12 10:21 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151112130901.GJ6445@suse.cz \
    --to=dsterba@suse.cz \
    --cc=holger.hoffstaette@googlemail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=s.priebe@profihost.ag \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox