From: Chris Mason <clm@fb.com>
To: <dsterba@suse.cz>, Filipe Manana <fdmanana@gmail.com>,
Justin Maggard <jmaggard10@gmail.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Justin Maggard <jmaggard@netgear.com>
Subject: Re: [PATCH] btrfs: qgroup: fix quota disable during rescan
Date: Thu, 19 Nov 2015 10:01:25 -0500 [thread overview]
Message-ID: <20151119150125.GA9887@ret.masoncoding.com> (raw)
In-Reply-To: <20151119132047.GD31035@twin.jikos.cz>
On Thu, Nov 19, 2015 at 02:20:47PM +0100, David Sterba wrote:
> On Thu, Nov 19, 2015 at 01:16:42PM +0000, Filipe Manana wrote:
> > On Thu, Nov 19, 2015 at 1:08 PM, David Sterba <dsterba@suse.cz> wrote:
> > > Hi,
> > >
> > > On Fri, Nov 06, 2015 at 10:36:42AM -0800, Justin Maggard wrote:
> > >> There's a race condition that leads to a NULL pointer dereference if you
> > >> disable quotas while a quota rescan is running. To fix this, we just need
> > >> to wait for the quota rescan worker to actually exit before tearing down
> > >> the quota structures.
> > >
> > > I see a reproducible crash in btrfs/115 (the fstest for this patch).
> > > This is with 4.4-rc1, so the patch is included:
> >
> > That's the expected crash, the patch isn't in 4.4-rc1.
>
> Aha, thanks. I got confused with the other fix, "btrfs: qgroup: exit
> the rescan worker during umount".
Me too, sorry Justin I'll get the other one too.
-chris
prev parent reply other threads:[~2015-11-19 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 18:36 [PATCH] btrfs: qgroup: fix quota disable during rescan Justin Maggard
2015-11-07 15:01 ` Filipe Manana
2015-11-19 13:08 ` David Sterba
2015-11-19 13:16 ` Filipe Manana
2015-11-19 13:20 ` David Sterba
2015-11-19 15:01 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119150125.GA9887@ret.masoncoding.com \
--to=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@gmail.com \
--cc=jmaggard10@gmail.com \
--cc=jmaggard@netgear.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox