From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org, codebird@birds-are-nice.me
Subject: Re: [PATCH V2] Btrfs: disable online scrub repair on ro cases
Date: Mon, 7 Dec 2015 15:37:43 +0100 [thread overview]
Message-ID: <20151207143743.GD4227@twin.jikos.cz> (raw)
In-Reply-To: <1449251884-24135-1-git-send-email-bo.li.liu@oracle.com>
On Fri, Dec 04, 2015 at 09:58:04AM -0800, Liu Bo wrote:
> This disables repair process on ro cases as it can cause system
> to be unresponsive on the ASSERT() in repair_io_failure().
>
> This can happen when scrub is running and a hardware error pops up,
> we should fallback to ro mounts gracefully instead of being unresponsive.
So this will also report the error as uncorrectable. This might be a bit
misleading, if a device error happens first and then some potentially
corectable errors are detected. This could be accounted as 'unverified'
error, that has closet maning.
next prev parent reply other threads:[~2015-12-07 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 0:55 [PATCH] Btrfs: disable online scrub repair on ro cases Liu Bo
2015-12-04 13:22 ` kbuild test robot
2015-12-04 13:35 ` kbuild test robot
2015-12-04 17:58 ` [PATCH V2] " Liu Bo
2015-12-07 14:37 ` David Sterba [this message]
2015-12-07 18:26 ` Liu Bo
2016-01-05 13:54 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207143743.GD4227@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=codebird@birds-are-nice.me \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).