linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc MERLIN <marc@merlins.org>
To: Filipe Manana <fdmanana@gmail.com>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>,
	David Sterba <dsterba@suse.cz>,
	Btrfs mailing list <linux-btrfs@vger.kernel.org>
Subject: Re: 4.4.0: btrfs-send BUG_ON(sctx->cur_ino != sctx->cmp_key->objectid);
Date: Mon, 25 Jan 2016 13:21:24 -0800	[thread overview]
Message-ID: <20160125212124.GL23751@merlins.org> (raw)
In-Reply-To: <CAL3q7H5rj4j10d34Wm_RxVf1yj4kg0tabCEHQdJrL2LyWUorCQ@mail.gmail.com>

On Mon, Jan 25, 2016 at 08:24:06PM +0000, Filipe Manana wrote:
> > The point is that my filesystem is damaged, but this is not a reason to
> > crash the kernel and the machine.
> 
> I've seen that happen on a non-damaged filesystem, for which I didn't
> get an image nor debug-tree's output before it got recreated. That's
> what I want to figure out, how/why it happened.
 
I'll see what I can do, this is going to take a lot of time on my end,
just before a trip and a system I have to bring back to working order
before I leave.

> > Can this be changed to an abort and remount read only instead?
> 
> Like many other bug_on's yes.

So, would you be able to first add the printk you requested to all
kernels since this info seems required for you to know more?
And then to change the BUG_ON into some kind of abort?
Crashing the kernel causes collateral damage, including getting the logs
you need to debug for many people without serial console :)

Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/                         | PGP 1024R/763BE901

  reply	other threads:[~2016-01-25 21:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18  0:27 BTRFS: bdev /dev/mapper/dshelf1 errs: wr 2970, rd 848, flush 0, corrupt 189, gen 0 Marc MERLIN
2016-01-18  3:21 ` Duncan
2016-01-18 23:39   ` Marc MERLIN
2016-01-19  9:39     ` Duncan
2016-01-21  4:52     ` Marc MERLIN
2016-01-23 17:03     ` Marc MERLIN
2016-01-23 23:13       ` Marc MERLIN
2016-01-25  1:37       ` Qu Wenruo
2016-01-25 15:55         ` 4.4.0: btrfs-send BUG_ON(sctx->cur_ino != sctx->cmp_key->objectid); Marc MERLIN
2016-01-25 19:46           ` Filipe Manana
2016-01-25 19:56             ` Marc MERLIN
2016-01-25 20:24               ` Filipe Manana
2016-01-25 21:21                 ` Marc MERLIN [this message]
2016-01-25 20:55         ` BTRFS: bdev /dev/mapper/dshelf1 errs: wr 2970, rd 848, flush 0, corrupt 189, gen 0 Marc MERLIN
2016-01-26  1:03           ` Qu Wenruo
2016-02-11  6:31             ` btrfs-image failure (btrfs-tools 4.4) Marc MERLIN
2016-02-11  7:16               ` Qu Wenruo
2016-02-11 15:09                 ` Marc MERLIN
2016-02-11 15:13                   ` Marc MERLIN
2016-02-12  0:33                     ` Qu Wenruo
2016-02-12 17:26                       ` Marc MERLIN
2016-02-14 17:26                         ` Marc MERLIN
2016-02-15  0:17                           ` Qu Wenruo
2016-02-15 16:40                             ` Marc MERLIN
2016-01-18 12:45 ` BTRFS: bdev /dev/mapper/dshelf1 errs: wr 2970, rd 848, flush 0, corrupt 189, gen 0 Hugo Mills

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160125212124.GL23751@merlins.org \
    --to=marc@merlins.org \
    --cc=dsterba@suse.cz \
    --cc=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).