From: David Sterba <dsterba@suse.cz>
To: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix error number in send.c
Date: Tue, 26 Jan 2016 14:01:00 +0100 [thread overview]
Message-ID: <20160126130100.GF8567@twin.jikos.cz> (raw)
In-Reply-To: <56A58737.906@jp.fujitsu.com>
On Mon, Jan 25, 2016 at 11:23:51AM +0900, Tsutomu Itoh wrote:
> Hi, David,
>
> On 2016/01/22 23:00, David Sterba wrote:
> > On Fri, Jan 22, 2016 at 09:13:25AM +0900, Tsutomu Itoh wrote:
> >> ENOTSUPP should not be returned to the user program.
> >> (cf. include/linux/errno.h)
> >> Therefore, EOPNOTSUPP is used instead of ENOTSUPP.
> >
> > I'm not sure that EOPNOTSUPP is the right error code here. I'd rather
> > make it EINVAL, the bug we're talking about is a new type of inode
> > outside of the S_IFMT bits. "not supported" would mean we don't support
> > it but we could in theory.
>
> Thanks for review.
>
> In the meaning that btrfs-send is not supporting a new type of inode now,
> EOPNOTSUPP is acceptable, I think.
It is, there's a warning message printed anyway, the actual error code
does not matter much.
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2016-01-26 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 0:13 [PATCH] Btrfs: fix error number in send.c Tsutomu Itoh
2016-01-22 14:00 ` David Sterba
2016-01-25 2:23 ` Tsutomu Itoh
2016-01-26 13:01 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126130100.GF8567@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=t-itoh@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).