linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* test fail for btrfs: synchronize incompat feature bits with sysfs files
@ 2016-01-27  6:57 Zhao Lei
  2016-01-27  8:48 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Zhao Lei @ 2016-01-27  6:57 UTC (permalink / raw)
  To: 'David Sterba'; +Cc: 'btrfs'

Hi, David Sterba

I find this patch caused NULL pointer accessing in lattest integration-4.5:
  btrfs: synchronize incompat feature bits with sysfs files
  CommitID: 14e46e04958df740c6c6a94849f176159a333f13

Several xfstests(as btrfs/103) failed with "BUG: unable to handle kernel NULL pointer..." warning.
Can be reproduced by following way:
  mkfs.btrfs -f /dev/sdb20
  mount -o "compress=lzo" /dev/sdb20 /mnt/tmp
  (panic)

Maybe caused by following reason:
(Only guessd by review source, hadn't trace to confirm)
 In open_ctree(), btrfs_parse_options()->btrfs_sysfs_feature_update()->sysfs_remove_group()
 is trying to remove fs_info->fs_devices->fsid_kobj, but this kobject is not initialized before.
 It is initialized in open_ctree() after btrfs_parse_options().

Cound you try to confirm it?

Thanks
Zhaolei





^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-27  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27  6:57 test fail for btrfs: synchronize incompat feature bits with sysfs files Zhao Lei
2016-01-27  8:48 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).