From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:23202 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbcBIBMC (ORCPT ); Mon, 8 Feb 2016 20:12:02 -0500 Subject: [PATCH 01/23] generic/182: this is a dedupe test, check for dedupe From: "Darrick J. Wong" To: david@fromorbit.com, darrick.wong@oracle.com Cc: linux-btrfs@vger.kernel.org, Christoph Hellwig , fstests@vger.kernel.org, xfs@oss.sgi.com Date: Mon, 08 Feb 2016 17:11:51 -0800 Message-ID: <20160209011151.23099.17497.stgit@birch.djwong.org> In-Reply-To: <20160209011145.23099.95354.stgit@birch.djwong.org> References: <20160209011145.23099.95354.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-btrfs-owner@vger.kernel.org List-ID: Since this test examines dedupe behavior, the documentation should say 'dedupe', not 'reflink'. Furthermore, the feature checks must look for working dedupe functionality, not reflink functionality. Signed-off-by: Darrick J. Wong [hch@lst.de: add the test for dedupe support] Signed-off-by: Christoph Hellwig --- tests/generic/182 | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/generic/182 b/tests/generic/182 index bf5cd38..ef10af8 100755 --- a/tests/generic/182 +++ b/tests/generic/182 @@ -1,10 +1,10 @@ #! /bin/bash # FS QA Test No. 182 # -# Test the convention that reflink with length == 0 means "to the end of fileA" +# Test the convention that dedupe with length == 0 means "to the end of fileA" # - Create a file. -# - Try to reflink "zero" bytes (which means reflink to EOF). -# - Check that the reflink happened. +# - Try to dedupe "zero" bytes (which means dedupe to EOF). +# - Check that the dedupe happened. # #----------------------------------------------------------------------- # Copyright (c) 2015, Oracle and/or its affiliates. All Rights Reserved. @@ -45,8 +45,7 @@ _cleanup() # real QA test starts here _supported_os Linux -_require_test_reflink -_require_cp_reflink +_require_test_dedupe rm -f "$seqres.full"