From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:41561 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbcBIHzQ (ORCPT ); Tue, 9 Feb 2016 02:55:16 -0500 Date: Mon, 8 Feb 2016 23:55:06 -0800 From: "Darrick J. Wong" To: Dave Chinner Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH 12/23] xfs/122: support refcount/rmap data structures Message-ID: <20160209075506.GB6346@birch.djwong.org> References: <20160209011145.23099.95354.stgit@birch.djwong.org> <20160209011303.23099.40721.stgit@birch.djwong.org> <20160209074330.GK19486@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160209074330.GK19486@dastard> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Feb 09, 2016 at 06:43:30PM +1100, Dave Chinner wrote: > On Mon, Feb 08, 2016 at 05:13:03PM -0800, Darrick J. Wong wrote: > > Include the refcount and rmap structures in the golden output. > > > > Signed-off-by: Darrick J. Wong > > --- > > tests/xfs/122 | 3 +++ > > tests/xfs/122.out | 4 ++++ > > tests/xfs/group | 2 +- > > 3 files changed, 8 insertions(+), 1 deletion(-) > > > > > > diff --git a/tests/xfs/122 b/tests/xfs/122 > > index e6697a2..758cb50 100755 > > --- a/tests/xfs/122 > > +++ b/tests/xfs/122 > > @@ -90,6 +90,9 @@ xfs_da3_icnode_hdr > > xfs_dir3_icfree_hdr > > xfs_dir3_icleaf_hdr > > xfs_name > > +xfs_owner_info > > +xfs_refcount_irec > > +xfs_rmap_irec > > xfs_alloctype_t > > xfs_buf_cancel_t > > xfs_bmbt_rec_32_t > > So this is going to cause failures on any userspace that doesn't > know about these new types, right? > > Should these be conditional in some way? I wasn't sure how to handle this -- I could just keep the patch at the head of my stack (unreleased) until xfsprogs pulls in the appropriate libxfs pieces? So long as we're not dead certain of the final format of the rmapbt and refcountbt, there's probably not a lot of value in putting this in (yet). --D > > Cheers, > > Dave. > > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html