From: Dan Carpenter <dan.carpenter@oracle.com>
To: zhaolei@cn.fujitsu.com
Cc: linux-btrfs@vger.kernel.org
Subject: re: btrfs: reada: simplify dev->reada_in_flight processing
Date: Wed, 17 Feb 2016 22:01:52 +0300 [thread overview]
Message-ID: <20160217190152.GA10246@mwanda> (raw)
Hello Zhao Lei,
The patch 7aff519c04d2: "btrfs: reada: simplify dev->reada_in_flight
processing" from Jan 12, 2016, leads to the following static checker
warning:
fs/btrfs/reada.c:697 reada_start_machine_dev()
warn: inconsistent indenting
fs/btrfs/reada.c
688 spin_unlock(&fs_info->reada_lock);
689 return 0;
690 }
691 dev->reada_next = re->logical + fs_info->tree_root->nodesize;
692 re->refcnt++;
693
694 spin_unlock(&fs_info->reada_lock);
695
696 spin_lock(&re->lock);
697 if (re->scheduled || list_empty(&re->extctl)) {
This is indented too much.
698 spin_unlock(&re->lock);
699 reada_extent_put(fs_info, re);
700 return 0;
701 }
702 re->scheduled = 1;
703 spin_unlock(&re->lock);
704
regards,
dan carpenter
next reply other threads:[~2016-02-17 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 19:01 Dan Carpenter [this message]
2016-02-18 1:37 ` btrfs: reada: simplify dev->reada_in_flight processing Zhao Lei
2016-02-18 9:39 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217190152.GA10246@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).