From: David Sterba <dsterba@suse.cz>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Anand Jain <anand.jain@oracle.com>,
kbuild-all@01.org,
"Chris Mason <chris.mason@fusionio.com> Chris Mason" <clm@fb.com>,
Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix ifnullfree.cocci warnings
Date: Thu, 18 Feb 2016 10:14:24 +0100 [thread overview]
Message-ID: <20160218091424.GV4374@suse.cz> (raw)
In-Reply-To: <20160217110441.GA21406@lkp-sb04>
On Wed, Feb 17, 2016 at 07:04:41PM +0800, kbuild test robot wrote:
> fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
> NULL check before some freeing functions is not needed.
>
> Based on checkpatch warning
> "kfree(NULL) is safe this check is probably not required"
> and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> CC: Anand Jain <anand.jain@oracle.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks, applied to the respective branch.
prev parent reply other threads:[~2016-02-18 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201602171939.Xe24Ni6m%fengguang.wu@intel.com>
2016-02-17 11:04 ` [PATCH] btrfs: fix ifnullfree.cocci warnings kbuild test robot
2016-02-18 9:14 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218091424.GV4374@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=fengguang.wu@intel.com \
--cc=jbacik@fb.com \
--cc=kbuild-all@01.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).