From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:45631 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425593AbcBRJOc (ORCPT ); Thu, 18 Feb 2016 04:14:32 -0500 Date: Thu, 18 Feb 2016 10:14:24 +0100 From: David Sterba To: kbuild test robot Cc: Anand Jain , kbuild-all@01.org, "Chris Mason Chris Mason" , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: fix ifnullfree.cocci warnings Message-ID: <20160218091424.GV4374@suse.cz> Reply-To: dsterba@suse.cz References: <201602171939.Xe24Ni6m%fengguang.wu@intel.com> <20160217110441.GA21406@lkp-sb04> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160217110441.GA21406@lkp-sb04> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, Feb 17, 2016 at 07:04:41PM +0800, kbuild test robot wrote: > fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Anand Jain > Signed-off-by: Fengguang Wu Thanks, applied to the respective branch.