From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:10657 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcB2Gns (ORCPT ); Mon, 29 Feb 2016 01:43:48 -0500 Date: Mon, 29 Feb 2016 17:43:45 +1100 From: Dave Chinner To: Qu Wenruo Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2 RESEND 2/5] fstests: btrfs: Add basic test for btrfs in-band de-duplication Message-ID: <20160229064345.GH29057@dastard> References: <1456301196-15874-1-git-send-email-quwenruo@cn.fujitsu.com> <1456301196-15874-3-git-send-email-quwenruo@cn.fujitsu.com> <20160228222627.GA29057@dastard> <56D3A733.7010608@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <56D3A733.7010608@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Mon, Feb 29, 2016 at 10:04:35AM +0800, Qu Wenruo wrote: > Hi Dave, > > Thanks for the review. > > All comment are correct and I'll update the patchset soon. > > Only one small question below > > Dave Chinner wrote on 2016/02/29 09:26 +1100: > ... > >>+# File size is twice the maximum file extent of btrfs > >>+# So even fallbacked to non-dedup, it will have at least 2 extents > >>+file_size=$(( 256 * 1024 * 1024 )) > > > >Used for xfs_io, so "file_size=256m" is all that is needed here. > > Super nice feature for support unit suffix, I checked man page of > xfs_io but only value for extsize mentioned the support for such > suffix. > > I assume all offset/length/bsize/value support suffix, right? Yes, they do, always have, originally came from other XFS commands (i.e see the mkfs.xfs for the "usual units suffixes" description). > Hope man page get updated. Can you send a patch? Cheers, Dave. -- Dave Chinner david@fromorbit.com