From: Eryu Guan <eguan@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: _fail the tests if _scratch_mount failed to avoid fully filling root fs
Date: Wed, 23 Mar 2016 11:23:29 +0800 [thread overview]
Message-ID: <20160323032329.GM11419@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160323000856.GY11812@dastard>
On Wed, Mar 23, 2016 at 11:08:56AM +1100, Dave Chinner wrote:
> On Mon, Mar 21, 2016 at 03:23:41PM +0800, Eryu Guan wrote:
> > btrfs failed to mount small fs on ppc64 host with error ENOSPC, even
> > creating such small fs succeeded, then generic/027 consumed all free
> > space on root fs not on SCRATCH_DEV and test harness cannot create tmp
> > files and continue other tests.
> >
> > Though I think it's a btrfs bug, it's still worth preventing this
> > situation from happening in the harness, as such tests usually aim to
> > exercise fs on ENOSPC conditions, there's no point to continue if the
> > small fs is not mounted.
>
> I think the btrfs bug should be fixed. At minimum, the workaround to
> see if the filesytem can be mounted should be in btrfs's
> implementation of scratch_mkfs_sized....
OK, I'll add workaround in _scratch_mkfs_sized. Thanks for reviewing!
Eryu
next prev parent reply other threads:[~2016-03-23 3:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 7:23 [PATCH] fstests: _fail the tests if _scratch_mount failed to avoid fully filling root fs Eryu Guan
2016-03-23 0:08 ` Dave Chinner
2016-03-23 3:23 ` Eryu Guan [this message]
2016-03-23 7:38 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323032329.GM11419@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).