linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: mkfs: fix an error when using DUP on multidev fs
Date: Wed, 30 Mar 2016 16:20:15 +0200	[thread overview]
Message-ID: <20160330142015.GD27917@twin.jikos.cz> (raw)
In-Reply-To: <56F49A96.70808@jp.fujitsu.com>

On Fri, Mar 25, 2016 at 10:55:34AM +0900, Satoru Takeuchi wrote:
> To accept DUP on multidev fs, in addition to the following
> commit, we need to mark DUP as an allowed data/metadata
> profile.
> 
> commit 42f1279bf8e9 ("btrfs-progs: mkfs: allow DUP on multidev fs, only warn")
> 
> * actual result
> 
>   =============================================
>   # ./mkfs.btrfs -f -m DUP -d DUP /dev/sdb1 /dev/sdb2
>   btrfs-progs v4.5-24-ga35b7e6
>   See http://btrfs.wiki.kernel.org for more information.
> 
>   WARNING: DUP is not recommended on filesystem with multiple devices
>   ERROR: unable to create FS with metadata profile DUP (have 2 devices but 1 devices are required)
>   =============================================
> 
> * expected result
> 
>   =============================================
>   # ./mkfs.btrfs -f -m dup -d dup /dev/sdb1 /dev/sdb2
>   WARNING: DUP is not recommended on filesystem with multiple devices
>   btrfs-progs v4.5-25-g1a10a3c
>   See http://btrfs.wiki.kernel.org for more information.
> 
>   Label:              (null)
>   UUID:               010d72ff-c87c-4516-8916-5e635719d110
>   Node size:          16384
>   Sector size:        4096
>   Filesystem size:    28.87GiB
>   Block group profiles:
>     Data:             DUP               1.01GiB
>     Metadata:         DUP               1.01GiB
>     System:           DUP              12.00MiB
>   SSD detected:       no
>   Incompat features:  extref, skinny-metadata
>   Number of devices:  2
>   Devices:
>      ID        SIZE  PATH
>       1   953.00MiB  /dev/sdb1
>       2    27.94GiB  /dev/sdb2
> 
>   ==================================================
> 
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

Applied, mkfs tests updated. Thanks.

  reply	other threads:[~2016-03-30 14:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 15:56 [PATCH] btrfs-progs: mkfs: allow DUP on multidev fs, only warn David Sterba
2016-03-25  1:55 ` [PATCH] btrfs-progs: mkfs: fix an error when using DUP on multidev fs Satoru Takeuchi
2016-03-30 14:20   ` David Sterba [this message]
2016-03-25  1:59 ` [PATCH] btrfs-progs: mkfs: allow DUP on multidev fs, only warn Duncan
2016-03-25  3:58   ` Hugo Mills

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330142015.GD27917@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=takeuchi_satoru@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).