From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: fsck: Fix a false metadata extent warning
Date: Fri, 1 Apr 2016 13:39:13 +0200 [thread overview]
Message-ID: <20160401113913.GA9918@suse.cz> (raw)
In-Reply-To: <56FE363E.5090202@cn.fujitsu.com>
On Fri, Apr 01, 2016 at 04:50:06PM +0800, Qu Wenruo wrote:
> > After another look, why don't we use nodesize directly? Or stripesize
> > where applies. With max_size == 0 the test does not make sense, we ought
> > to know the alignment.
> >
> Yes, my first though is also to use nodesize directly, which should be
> always correct.
>
> But the problem is, the related function call stack doesn't have any
> member to reach btrfs_root or btrfs_fs_info.
>
> In the very beginning version of such crossing stripe check, I used to
> add a btrfs_root/btrfs_fs_info parameter to the function.
>
> But the code change are too many, so I use 'max_size'.
>
> I can try to re-do such modification, but IIRC it didn't cause a good
> result.
Yes it would require refactoring, which would be good on itself, because
add_extent_rec takes 12(!) parameters. Some of its callers would need to
be updated, but it seems doable.
next prev parent reply other threads:[~2016-04-01 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 2:19 [PATCH] btrfs-progs: fsck: Fix a false metadata extent warning Qu Wenruo
2016-03-31 16:30 ` David Sterba
2016-04-01 0:28 ` Qu Wenruo
2016-04-01 8:44 ` David Sterba
2016-04-01 8:50 ` Qu Wenruo
2016-04-01 11:39 ` David Sterba [this message]
2016-04-01 12:09 ` Qu Wenruo
2016-04-01 12:48 ` David Sterba
2016-04-04 11:18 ` David Sterba
2016-04-05 1:28 ` Qu Wenruo
2016-04-05 8:43 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401113913.GA9918@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).