linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Borowski <kilobyte@angband.pl>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Josef Bacik <jbacik@fb.com>, Dave Jones <davej@codemonkey.org.uk>,
	Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: btrfs_destroy_inode WARN_ON.
Date: Tue, 26 Apr 2016 03:40:35 +0200	[thread overview]
Message-ID: <20160426014035.GA11882@angband.pl> (raw)
In-Reply-To: <20160328141446.GB308@x4>

On Mon, Mar 28, 2016 at 04:14:46PM +0200, Markus Trippelsdorf wrote:
> On 2016.03.28 at 10:05 -0400, Josef Bacik wrote:
> > >Mar 24 10:37:27 x4 kernel: WARNING: CPU: 3 PID: 11838 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0x22b/0x2a0
> > 
> > I saw this running some xfstests on our internal kernels but haven't been
> > able to reproduce it on my latest enospc work (which is obviously perfect).
> > What were you doing when you tripped this?  I'd like to see if I actually
> > did fix it or if I still need to run it down.  Thanks,
> 
> I cannot really tell. Looking at the backtrace, both Dave and I were
> running rm. 
> This warning happened just once on my machine, so the issue is obviously
> very hard to trigger.

On the other hand, it seems to be triggering really often (on the order of
~10 mins of light use) on my box.  I understandably ran away from 4.6-rc to
stable kernels (no one likes to risk data loss), but even in that little
time it triggered 328 times (over ~20ish boots).

Despite all of these WARNs, there's no data loss yet on the disk in
question, and the filesystem appears consistent.

Call stacks show a variety of callers of btrfs_destroy_inode, originating
from do_unlinkat, SyS_rename, btrfs_ioctl_snap_destroy, shrink_zone, or
task_work_run, direct callers being:

do_unlinkat

__dentry_kill
dput

__dentry_kill
shrink_dentry_list

dispose_list
prune_icache_sb


Just tried 4.6-rc5, it's still there.

Any way I could help debug this?

-- 
A tit a day keeps the vet away.

  reply	other threads:[~2016-04-26  2:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 22:54 btrfs_destroy_inode WARN_ON Dave Jones
2016-03-25  8:25 ` Markus Trippelsdorf
2016-03-28 14:05   ` Josef Bacik
2016-03-28 14:14     ` Markus Trippelsdorf
2016-04-26  1:40       ` Adam Borowski [this message]
2016-03-28  1:14 ` Dave Jones
2016-04-01 18:12   ` Dave Jones
2016-04-01 18:18     ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426014035.GA11882@angband.pl \
    --to=kilobyte@angband.pl \
    --cc=clm@fb.com \
    --cc=davej@codemonkey.org.uk \
    --cc=dsterba@suse.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).