Re: [PATCH v2] btrfs: cleanup assigning next active device with a check

[David Sterba <dsterba@suse.cz>]

On Tue, May 03, 2016 at 07:47:28PM +0200, David Sterba wrote:
> On Tue, May 03, 2016 at 06:01:31PM +0800, Anand Jain wrote:
> > 
> > 
> > On 05/02/2016 11:26 PM, David Sterba wrote:
> > > On Mon, May 02, 2016 at 07:02:08AM +0800, Anand Jain wrote:
> > >> --- a/fs/btrfs/dev-replace.c
> > >> +++ b/fs/btrfs/dev-replace.c
> > >> @@ -569,11 +569,9 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
> > >>   	ASSERT(list_empty(&src_device->resized_list));
> > >>   	tgt_device->commit_total_bytes = src_device->commit_total_bytes;
> > >>   	tgt_device->commit_bytes_used = src_device->bytes_used;
> > >> -	if (fs_info->sb->s_bdev &&
> > >> -		(fs_info->sb->s_bdev == src_device->bdev))
> > >> -		fs_info->sb->s_bdev = tgt_device->bdev;
> > >
> > > What's the base of this patch?
> > 
> >   It was on master. But now the V3 which is based on your for-next.
> > 
> > > The above code is not in my for-next so
> > > I could be missing some important bits.
> > 
> >   Yes. That was added by this patch.
> > 
> >   [PATCH] btrfs: s_bdev is not null after missing replace
> 
> Ah, that's the one. Added to next together with v3, though a testcase is
> still desirable.

There were some merge conflicts with the dev-del-by-id patchset so I've
put the patches there.