From: David Sterba <dsterba@suse.cz>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] btrfs-progs: prop: convert error messages to use error()
Date: Mon, 9 May 2016 17:56:02 +0200 [thread overview]
Message-ID: <20160509155601.GL29353@twin.jikos.cz> (raw)
In-Reply-To: <57303A21.9070308@jp.fujitsu.com>
On Mon, May 09, 2016 at 04:20:01PM +0900, Satoru Takeuchi wrote:
> props.c uses 'fprintf(stderr, "ERROR: ...")' as its error messages,
> however we have generic error() function.
>
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
All applied, thanks. I did some minor tweaks to the messages in 1/3 to
be consistent with the rest.
prev parent reply other threads:[~2016-05-09 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 7:20 [PATCH 1/3] btrfs-progs: prop: convert error messages to use error() Satoru Takeuchi
2016-05-09 7:49 ` [PATCH 2/3] btrfs-progs: prop: simplify parse_args() Satoru Takeuchi
2016-05-09 7:52 ` [PATCH 3/3] btrfs-progs: prop: remove conditions which never be satisfied Satoru Takeuchi
2016-05-09 15:56 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509155601.GL29353@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=takeuchi_satoru@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).