Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Nicholas D Steeves <nsteeves@gmail.com>
Cc: Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Trivial fix for typos in comments.
Date: Wed, 11 May 2016 10:56:07 +0200	[thread overview]
Message-ID: <20160511085607.GY29353@suse.cz> (raw)
In-Reply-To: <CAD=QJKjYTv4-7srx2zPTJNnF97BFFsQ4kLz3+PpC_Qgfb3b33Q@mail.gmail.com>

On Tue, May 10, 2016 at 07:42:50PM -0400, Nicholas D Steeves wrote:
> On 10 May 2016 at 09:33, David Sterba <dsterba@suse.cz> wrote:
> > On Mon, May 09, 2016 at 08:13:29PM -0400, Nicholas D Steeves wrote:
> >> Trivial fix for typos in comments; I hope this patch isn't a nuisance!
> >
> > No, but I don't see the typos in any of the branches (master or the
> > for-next snapshots).
> 
> Sorry, I used for-linus, while following this guide:
> "git clone git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git
> for-linus"
> https://btrfs.wiki.kernel.org/index.php/Writing_patch_for_btrfs
> 
> and "git checkout master" confirms that I'm already on 'master', but
> "git rebase next" produces the error:
> 
> fatal: Needed a single revision
> invalid upstream next

You'd need to have the linux-next git tree or my kernel.org tree
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git

> I'm very new to git.  Should I have cloned the whole linux-btrfs.git
> without "for-linus"?  Am I on the a master branch for the for-linus
> module, which is separate from the master branch of the main
> linux-btrfs?

If not sure, look at other branches, timestamps etc. The plain for-linus
in chris' repo is from january and on top of 4.3. There are other
for-linus branches with a version. There's no predefined style for
naming so it could be confusing. Git comes with a nice feature
'git instaweb' that will present the local git repository in a web
browser and it's very handy for quick peeks into other branches.

> On 10 May 2016 at 10:20, David Sterba <dsterba@suse.cz> wrote:
> Message-ID: <20160510142028.GU29353@twin.jikos.cz>
> > On Mon, May 09, 2016 at 08:13:29PM -0400, Nicholas D Steeves wrote:
> > I ran ispell on the strings from comments, there are like 90+ typos
> > (attached) that seem worth fixing, if you like.
> 
> Thank you for the list, I'd be happy to.  Are patches against master
> or next preferred (I don't see a for-next branch)?

The for-next branch is in my kenrel.org repo, otherwise the snapshots
(named like for-next-20160510) are hosted in my development
repositories. Basing on master should be fine, the for-next branches are
sort of in flux so we could miss some typos from there, but no big deal.
The list I sent was from master sources.

  reply	other threads:[~2016-05-11  8:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10  0:13 [PATCH] Trivial fix for typos in comments Nicholas D Steeves
2016-05-10  0:13 ` Nicholas D Steeves
2016-05-10 13:33 ` David Sterba
2016-05-10 23:42   ` Nicholas D Steeves
2016-05-11  8:56     ` David Sterba [this message]
2016-05-10 14:20 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160511085607.GY29353@suse.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nsteeves@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox